Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIIN-3210 Remove hover-over text next to "Shelving order" on the Item record detail view #2729

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

UIIN-3210 Remove hover-over text next to "Shelving order" on the Item record detail view #2729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f98ab0
UIIN-3210 Remove hover-over text next to "Shelving order" on the Item…
BogdanDenis Feb 3, 2025
f3f9811
UIIN-3210 update test
BogdanDenis Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
* ECS: Disable opening item details if a user is not affiliated with item's member tenant. Fixes UIIN-3187.
* Correctly depend on `inflected`. Refs UIIN-3203.
* Decrease the amount of rerenders in `ConsortialHoldings` component. Fixes UIIN-3196.
* Remove hover-over text next to "Shelving order" on the Item record detail view. Refs UIIN-3210.

## [12.0.12](https://github.com/folio-org/ui-inventory/tree/v12.0.12) (2025-01-27)
[Full Changelog](https://github.com/folio-org/ui-inventory/compare/v12.0.11...v12.0.12)
Expand Down
6 changes: 0 additions & 6 deletions src/views/ItemView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ import {
HasCommand,
collapseAllSections,
expandAllSections,
InfoPopover,
Layout,
MenuSection,
NoValue,
Expand Down Expand Up @@ -1272,11 +1271,6 @@ const ItemView = props => {
label={<FormattedMessage id="ui-inventory.shelvingOrder" />}
value={checkIfElementIsEmpty(itemData.effectiveShelvingOrder)}
/>
<InfoPopover
iconSize="medium"
content={<FormattedMessage id="ui-inventory.info.shelvingOrder" />}
buttonProps={{ 'data-testid': 'info-icon-shelving-order' }}
/>
</Layout>
</Col>
</Row>
Expand Down
4 changes: 0 additions & 4 deletions src/views/ItemView.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,10 +282,6 @@ describe('ItemView', () => {
});
});

it('should display the information icons', () => {
expect(screen.getAllByTestId('info-icon-shelving-order')[0]).toBeDefined();
});

describe('when close view page', () => {
it('should call the function to redirect user to instance page', () => {
checkIfUserInCentralTenant.mockClear().mockReturnValue(false);
Expand Down
1 change: 0 additions & 1 deletion translations/ui-inventory/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,7 +868,6 @@
"administrativeNote": "Administrative note",
"administrativeNotes": "Administrative notes",
"linkedToMarcAuthority": "Linked to MARC authority",
"info.shelvingOrder": "This field is the normalized form of the call number which determines how the call number is sorted while browsing.",

"shortcut.nextSubfield": "quickMARC only: Move to the next subfield in a text box",
"shortcut.prevSubfield": "quickMARC only: Move to the previous subfield in a text box",
Expand Down
Loading