feat(gitbrowse): get commit hash from current line on open

[whoop-t]

Description

Allow gitbrowse to get the current line commit hash when using Snacks.gitbrowse.open()

Related Issue(s)

Currently you must hover the word of the actually commit hash. This requires you opening git blame(or something similar) and hovering the word of the commit hash you want to open.

I feel like this is kind of clunky and would it would be nicer to just be able to open commit url straight from file/line.

[whoop-t]

Similar to: #393

[dpetka2001]

How would you open file/branch/repo then?

[whoop-t]

How would you open file/branch/repo then?

You would change the what in the opts, commit should still just fallback like it already does.

I altered it a bit: 31ebdb4

[dpetka2001]

snacks.nvim/lua/snacks/gitbrowse.lua

Lines 192 to 200 in 70e7e08

	if not fields.commit and (opts.what == "commit" or opts.what == "permalink") then
	opts.what = "file"
	end
	if not fields.commit and not fields.file then
	opts.what = "branch"
	end
	if not fields.commit and not fields.branch then
	opts.what = "repo"
	end

These will never execute if you always set fields.commit. It's supposed to automatically switch the opts.what based on the content under the cursor without the user having to explicitly specify it.

#1371 will expose opts.commit and then users can implement this logic in their personal configuration if they want to.

[whoop-t]

@dpetka2001 I guess then what's the point of setting what = "commit" if it just does stuff automatically.

Why not have another option like auto or something?

Without looking at the code it's kinda unclear what it will do when setting it to commit

[dpetka2001]

what = "commit" is just the starting point and based on the context under the cursor it changes automatically if needed or not. You're supposed to put your cursor somewhere and based on that the appropriate action is taken. You're supposed to put the cursor on top of a commit sha if you want to trigger that action.

Anyhow, maintainer has the final say. I'm just a simple user.

[whoop-t]

@dpetka2001 Its all good, this isnt super important but thought it was worth a discussion.

No where does it say you need to hover a commit sha for what = "commit"(the default setting) to work(unless you look at the code) so I think that will cause confusion. Im just coming from another plugin that if you say "i want to open the commit", thats what it does.

Maybe just a note somewhere as this confused me till I looked at the code.

Thanks for the back and forth