Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define NO_TFO on macOS < 10.11 #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

barracuda156
Copy link

Closes: #19

Copy link
Owner

@folkertvanheusden folkertvanheusden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this could be done in the cmake file?

@barracuda156
Copy link
Author

@folkertvanheusden Perhaps, I am just not really sure how to check for macOS version via CMakeLists.

@folkertvanheusden
Copy link
Owner

folkertvanheusden commented Sep 26, 2024 via email

@barracuda156
Copy link
Author

I think it can be done via https://stackoverflow.com/questions/27660048/cmake-check-if-mac-os-x-use-apple-or-apple Don't have a mac so can't test it.

On Thu, Sep 26, 2024 at 9:13 PM Sergey Fedorov @.> wrote: @folkertvanheusden https://github.com/folkertvanheusden Perhaps, I am just not really sure how to check for macOS version via CMakeLists. — Reply to this email directly, view it on GitHub <#22 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUN5IW36ERW4UQQLBZIQ3HLZYRMGVAVCNFSM6AAAAABO5N47POVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZXG4ZTQMBQGQ . You are receiving this because you were mentioned.Message ID: @.>

Yeah, but we do not want to disable it for all macOS altogether. Only for versions prior to 10.11.

@yegorich
Copy link
Contributor

yegorich commented Feb 3, 2025

There is an interesting discussion about TFO support in different distros/versions/archs: rust-lang/socket2#49

@yegorich
Copy link
Contributor

yegorich commented Feb 3, 2025

Checking symbols with CMake: https://cmake.org/cmake/help/latest/module/CheckSymbolExists.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants