-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RELEASE: @W-13805530@: Merging dev to release for 3.15.0 #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NEW (GraphEngine): @W-13569661@: Adds new rule, DmlInLoopRule
CHANGE (CodeAnalyzer): @W-13644357@: Updated README.
NEW (CodeAnalyzer): @W-12943227@: Adds sample project for writing Java-based PMD custom rules.
…seOperationInLoop
CHANGE (GraphEngine): @W-13569661@: Rename DmlInLoopRule to AvoidDatabaseOperationInLoop, update UI text
…assSchemaLookups.
CHANGE (GraphEngine): @W-13720122@: MultipleMassSchemaLookupRule going GA as AvoidMultipleMassSchemaLookups.
…lations from ignorefile.
CHANGE (ESLint): @W-8458220@: Custom ESLint config discards noisy violations from ignorefile.
@W-13569669@: fix typo in warning logic @W-13569669@: fix exceptions in SharingPolicySymbolProviderVertexVisitor @W-13569669@: clean up comments for warning code @W-13569669@: update tests to use 2d arrays @W-13569669@: combine SharingPolicyWarningBuilder into SharingPolicyViolationBuilder @W-13569669@: formatting @W-13569669@: fix Database method tests using invalid Account constructor @W-13569669@: use isEmpty on stack instead of CollectionUtil @W-13569669@: change "applicable ancestor" to "applicable superclass" @W-13569669@: fix and disable tests for abstract class, add test comments @W-13569669@: fix and disable test for abstract class @W-13569669@: fix generics for SharingPolicyBoundary @W-13569669@: remove redundant query in SharingPolicyBoundary @W-13569669@: fix tests to enable Sharing rule @W-13569669@: remove parameter from findAncestorWithExplicitSharingPolicy helper method in SharingPolicyBoundary @W-13569669@: add clarifying first-boundary comment @W-13569669@: remove redundant warning tests @W-13569669@: enable UseWithSharingOnDatabaseOperation @W-13569669@: move SharingPolicy enum values to ASTConstants, stop storing omitted declaration on modifier node @W-13569669@: move DatabaseOperationUtil to ops package, update comments and nested/braceless ifs @W-13569669@: move SharingPolicySymbolProviderVertexVisitor to rule package @W-13569669@: change warning logic & messaging for edge cases @W-13569669@: clean up UseWithSharingOnDatabaseOpeartion testing @W-13569669@: fix logic to find Method vertex from MethodCallExpression, testing @W-13569669@: add path test @W-13569669@: remove redundant tests, add method resolving tests @W-13569669@: remove redundant sharing policy test @W-13569669@: clean up in UseWithSharing rule @W-13569669@: better encapsulation for DatabaseOperationUtil and AvoidDmlInLoopRule move testing if database operation is a violation in a loop from DatabaseOperationUtil into AvoidDatabaseOperationInLoopVisitor.java @W-13569669@: rename DmlUtil to DatabaseOpeartionUtil @W-13569669@: fix typo in AvoidDatabaseOperationInLoopVisitor.java @W-13569669@: clean up stray comments in SharingPolicy @W-13569669@: move SharingPolicy to its own Enum, fix import errors for DmlUtil @W-13569669@: use approved UI text for Sharing Policy rule @W-1369669@: clean up @W-1369669@: finalize warning logic, add documentation @W-1369669@: rework warning logic for Sharing Policy, not done yet @W-1369669@: formatting @W-1369669@: make SharingPolicy warnings obey configuration @W-1369669@: fix tests for new Sharing Policy Omitted_Policy label @W-1369669@: disable some Sharing Policy warning testing, todo @W-1369669@: formatting @W-1369669@: change omitted sharing policy property ModifierNode wil now have a well-defined string if a sharing policy is omitted instead of null/nothig @W-1369669@: more testing, comments for Sharing Policy rule @W-13569669@: add simple parent inheritance tests for sharing policy @W-13569669@: refactor complex tests for UseWithSharingOnDatabaseOperation @W135-69669@: formatting for UseWithSharingOnDatabaseOpeartion testing @W135-69669@: add, update testing for UseWithSharingOnDatabaseOperation @W-13569669@: clean up comments, rename SharingPolicyRule to UseWithSharingOnDatabaseOperation @W-13569669@: update, add sharing policy tests @W-13569669@: finalize SharingPolicy warning logic, add test @W-13569669@: move detection of applicable ancestral sharing policy to SharingPolicyBoundary @W-15369669@: update logic for inheriting sharing policy @W-13569669@: refactor SharingPolicyRule, allow inheriteing policies from ancestral classes @W-13569669@: Refactor and add new tests for SharingPolicyRule @W-13569669@: fix SharingPolicyTests @W-13569669@: add most sharing logic + inheritance logic, more tests @W-13569669@: basic sharing policy detection, basic tests passing, lots to do @W-13569669@: add Sharing Policy property to ModifierNode @W-13569669@: formatting from spotless @W-13569669@: Create basic SharingPolicyRule stubs @W-13569669@: move detection of DML/SOQL vertices DmlUtil for reuse
NEW (GraphEngine): @W-13569669@: Adds new rule, UseWithSharingOnDatabaseOperation
CHANGE (GraphEngine): @W-13790909@: Renamed UnusedMethodRule to RemoveUnusedMethod
CHANGE (GraphEngine): @W-13720122@: Adjusted MMS rule URL to new value.
CHANGE (GraphEngine): @W-13790909@: Adjusted url for RemoveUnusedMethod.
FIX (GraphEngine): @W-13569669@: fixes bugs found in QA of UseWithSharingOnDatabaseOperation
…t to the proper anchors.
FIX (GraphEngine): @W-13848149@: Adjusted violation URLs so they point to the proper anchors.
NEW (CodeAnalyzer): @W-13805530@: RetireJS and package updates for 3.15.0 release.
ranekere-sfdc
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.