Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RELEASE: @W-13805530@: Merging dev to release for 3.15.0 #1136

Merged
merged 52 commits into from
Aug 1, 2023
Merged

Conversation

jfeingold35
Copy link
Collaborator

No description provided.

MrEminent42 and others added 30 commits July 6, 2023 14:42
NEW (GraphEngine): @W-13569661@: Adds new rule, DmlInLoopRule
CHANGE (CodeAnalyzer): @W-13644357@: Updated README.
NEW (CodeAnalyzer): @W-12943227@: Adds sample project for writing Java-based PMD custom rules.
MrEminent42 and others added 22 commits July 20, 2023 09:13
CHANGE (GraphEngine): @W-13569661@: Rename DmlInLoopRule to AvoidDatabaseOperationInLoop, update UI text
CHANGE (GraphEngine): @W-13720122@: MultipleMassSchemaLookupRule going GA as AvoidMultipleMassSchemaLookups.
CHANGE (ESLint): @W-8458220@: Custom ESLint config discards noisy violations from ignorefile.
@W-13569669@: fix typo in warning logic

@W-13569669@: fix exceptions in SharingPolicySymbolProviderVertexVisitor

@W-13569669@: clean up comments for warning code

@W-13569669@: update tests to use 2d arrays

@W-13569669@: combine SharingPolicyWarningBuilder into SharingPolicyViolationBuilder

@W-13569669@: formatting

@W-13569669@: fix Database method tests using invalid Account constructor

@W-13569669@: use isEmpty on stack instead of CollectionUtil

@W-13569669@: change "applicable ancestor" to "applicable superclass"

@W-13569669@: fix and disable tests for abstract class, add test comments

@W-13569669@: fix and disable test for abstract class

@W-13569669@: fix generics for SharingPolicyBoundary

@W-13569669@: remove redundant query in SharingPolicyBoundary

@W-13569669@: fix tests to enable Sharing rule

@W-13569669@: remove parameter from findAncestorWithExplicitSharingPolicy helper method in SharingPolicyBoundary

@W-13569669@: add clarifying first-boundary comment

@W-13569669@: remove redundant warning tests

@W-13569669@: enable UseWithSharingOnDatabaseOperation

@W-13569669@: move SharingPolicy enum values to ASTConstants, stop storing omitted declaration on modifier node

@W-13569669@: move DatabaseOperationUtil to ops package, update comments and nested/braceless ifs

@W-13569669@: move SharingPolicySymbolProviderVertexVisitor to rule package

@W-13569669@: change warning logic & messaging for edge cases

@W-13569669@: clean up UseWithSharingOnDatabaseOpeartion testing

@W-13569669@: fix logic to find Method vertex from MethodCallExpression, testing

@W-13569669@: add path test

@W-13569669@: remove redundant tests, add method resolving tests

@W-13569669@: remove redundant sharing policy test

@W-13569669@: clean up in UseWithSharing rule

@W-13569669@: better encapsulation for DatabaseOperationUtil and AvoidDmlInLoopRule

move testing if database operation is a violation in a loop from DatabaseOperationUtil into AvoidDatabaseOperationInLoopVisitor.java

@W-13569669@: rename DmlUtil to DatabaseOpeartionUtil

@W-13569669@: fix typo in AvoidDatabaseOperationInLoopVisitor.java

@W-13569669@: clean up stray comments in SharingPolicy

@W-13569669@: move SharingPolicy to its own Enum, fix import errors for DmlUtil

@W-13569669@: use approved UI text for Sharing Policy rule

@W-1369669@: clean up

@W-1369669@: finalize warning logic, add documentation

@W-1369669@: rework warning logic for Sharing Policy, not done yet

@W-1369669@: formatting

@W-1369669@: make SharingPolicy warnings obey configuration

@W-1369669@: fix tests for new Sharing Policy Omitted_Policy label

@W-1369669@: disable some Sharing Policy warning testing, todo

@W-1369669@: formatting

@W-1369669@: change omitted sharing policy property

ModifierNode wil now have a well-defined string if a sharing policy is omitted instead of null/nothig

@W-1369669@: more testing, comments for Sharing Policy rule

@W-13569669@: add simple parent inheritance tests for sharing policy

@W-13569669@: refactor complex tests for UseWithSharingOnDatabaseOperation

@W135-69669@: formatting for UseWithSharingOnDatabaseOpeartion testing

@W135-69669@: add, update testing for UseWithSharingOnDatabaseOperation

@W-13569669@: clean up comments, rename SharingPolicyRule to UseWithSharingOnDatabaseOperation

@W-13569669@: update, add sharing policy tests

@W-13569669@: finalize SharingPolicy warning logic, add test

@W-13569669@: move detection of applicable ancestral sharing policy to SharingPolicyBoundary

@W-15369669@: update logic for inheriting sharing policy

@W-13569669@: refactor SharingPolicyRule, allow inheriteing policies from ancestral classes

@W-13569669@: Refactor and add new tests for SharingPolicyRule

@W-13569669@: fix SharingPolicyTests

@W-13569669@: add most sharing logic + inheritance logic, more tests

@W-13569669@: basic sharing policy detection, basic tests passing, lots to do

@W-13569669@: add Sharing Policy property to ModifierNode

@W-13569669@: formatting from spotless

@W-13569669@: Create basic SharingPolicyRule stubs

@W-13569669@: move detection of DML/SOQL vertices DmlUtil for reuse
NEW (GraphEngine): @W-13569669@: Adds new rule, UseWithSharingOnDatabaseOperation
CHANGE (GraphEngine): @W-13790909@: Renamed UnusedMethodRule to RemoveUnusedMethod
CHANGE (GraphEngine): @W-13720122@: Adjusted MMS rule URL to new value.
CHANGE (GraphEngine): @W-13790909@: Adjusted url for RemoveUnusedMethod.
FIX (GraphEngine): @W-13569669@: fixes bugs found in QA of UseWithSharingOnDatabaseOperation
FIX (GraphEngine): @W-13848149@: Adjusted violation URLs so they point to the proper anchors.
NEW (CodeAnalyzer): @W-13805530@: RetireJS and package updates for 3.15.0 release.
@ranekere-sfdc ranekere-sfdc self-requested a review August 1, 2023 17:05
@jfeingold35 jfeingold35 marked this pull request as ready for review August 1, 2023 17:05
@jfeingold35 jfeingold35 merged commit 4ee7258 into release Aug 1, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants