Better readable network difficulty + correct readable hash rate calculation #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When difficulty is 1598298868 (for example) it's not readable. 1.49 GH is much better to read.
The denomination of hash rates follows the International System of Units (SI) https://bitcoin.stackexchange.com/a/21498
Anton-Beresansky
changed the title
The denomination of hash rates follows the International System of Units (SI) https://bitcoin.stackexchange.com/a/21498
Created function to get readable difficulty string
|
Sorry for errors. Now it's must be correct. Tested on my own pool. |
|
Are you sure this is correct? Doesn't it still need to be represented with the H, eg. GH. Its great the extra units are added and the K-k is corrected though :) |
|
It was the first thing I did - started to use getReadableHashRateString for difficulty. Then I've made some research and find out that difficulty should be without H, so I created a separate function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When difficulty is 1598298868 (for example) it's not readable. 1.60 G is much better to read.
The denomination of hash rates follows the International System of Units (SI)
https://bitcoin.stackexchange.com/a/21498