feat: connect github app to our web app #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
mattinannt
reviewed
Feb 6, 2024
| @@ -5,7 +5,8 @@ import { Octokit } from "@octokit/rest" | |||
|
|
|||
| import { GITHUB_APP_APP_ID } from "./constants" | |||
|
|
|||
| const resolvedPath = path.resolve(__dirname, "../../../../key.pem") | |||
| const privateKeyPath = "../../../../key.pem" | |||
There was a problem hiding this comment.
@ShubhamPalriwala How can we solve the key.pem requirement in the cloud?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Connects the Github App to our Web App!
It does not focus on implementing services and following cleanest of best practices because @Dhruwang already has a PR open which once merged, then this can be rewritten to support the style there.
The focus here was to get the functionality live!
PS: Took wayy longer than expected due to Octokit's Auth issues so had to debug and rewrite that!
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated