Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTE-294] Specify install directory libraries #379

Merged

Conversation

raoulstrackx
Copy link
Contributor

Since mbedtls 2.28.8 they changed where libraries are installed on some platforms (e.g., on Amazon Linux it ends up in a lib64 library, on ubuntu it's lib). This causes issues like:
error: could not find native static library mbedtls, perhaps an -L flag is missing?

error: could not compile mbedtls-platform-support (lib) due to 1 previous error

The issue has been resolved on the mbedtls-sys-auto-2.28.9_old-bindgen branch in rust-mbedtls PR377 and rust-mbedtls PR378. This PR combines boths PRs and targets the master branch.

@raoulstrackx raoulstrackx requested a review from Taowyoo January 13, 2025 08:54
Copy link

Benchmark for b370ef7

Click to view benchmark
Test Base PR %
Cipher/AES CBC decrypt 310.3±11.39ns 310.6±19.42ns +0.10%
Cipher/AES CBC encrypt 218.9±11.54ns 215.6±14.55ns -1.51%
Cipher/AES CCM decrypt 399.5±16.45ns 397.1±10.70ns -0.60%
Cipher/AES CCM encrypt 364.6±13.09ns 354.3±9.97ns -2.83%
Cipher/AES GCM decrypt 641.5±15.97ns 560.9±18.34ns -12.56%
Cipher/AES GCM encrypt 563.2±37.10ns 646.5±26.51ns +14.79%
Cipher/AES KW decrypt 668.4±14.23ns 651.1±18.14ns -2.59%
Cipher/AES KW encrypt 599.3±17.00ns 590.1±22.58ns -1.54%
Cipher/AES KWP decrypt 681.8±13.92ns 671.3±22.70ns -1.54%
Cipher/AES KWP encrypt 608.8±14.09ns 613.0±30.08ns +0.69%

@Pagten Pagten self-requested a review January 13, 2025 09:02
Copy link
Collaborator

@Pagten Pagten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@raoulstrackx raoulstrackx merged commit 68fdeb6 into master Jan 13, 2025
11 checks passed
@raoulstrackx raoulstrackx deleted the raoul/rte-294-specify_install_directory_libraries branch January 13, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants