Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffdhe branch: tracking PR to run CI #28

Closed
wants to merge 18 commits into from
Closed

ffdhe branch: tracking PR to run CI #28

wants to merge 18 commits into from

Conversation

s-arash
Copy link
Collaborator

@s-arash s-arash commented Dec 20, 2023

No description provided.

s-arash and others added 2 commits December 19, 2023 23:01
* Implement FFDHE support in mbedcrypto-provider

* Add test for bad FFDHE public keys

* Address review comments

* Update rustls dependency to one based on 0.22.1 in Cargo.lock

---------

Co-authored-by: Arash Sahebolamri <[email protected]>
@s-arash s-arash changed the title Tracking PR to run CI ffdhe branch: tracking PR to run CI Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cbe4647) 94.58% compared to head (e7ce2fa) 94.28%.
Report is 3 commits behind head on master.

❗ Current head e7ce2fa differs from pull request most recent head b17ad07. Consider uploading reports for the commit b17ad07 to get more accurate results

Files Patch % Lines
rustls-mbedcrypto-provider/src/kx.rs 98.38% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   94.58%   94.28%   -0.31%     
==========================================
  Files          17       16       -1     
  Lines        2272     2169     -103     
==========================================
- Hits         2149     2045     -104     
- Misses        123      124       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

s-arash and others added 16 commits December 20, 2023 13:29
…s-list

Avoid sending empty root hints list
Export types enable user to create customized cipher suites.
+ Update rustls dep to `ffdhe-r3`
…nce)

    - Apply suggestions from code review
    - Co-authored-by: YX Cao <[email protected]>
    - Signed-off-by: Arash Sahebolamri <[email protected]>
Upgrade rustls to add support of new config option
for requiring peer support of extended master secret
extension.
Upgrade rustls to tag `ffdhe-r4` for new config support:

Upgrade rustls to add support of new config option for requiring peer support of extended master secret extension.
This PR merges `master` into `ffdhe` which results following changes:

- Update `mbedtls` version to `0.12.2`
- Bump some dependencies version in Cargo.lock file.
- Add a Known answer Cryptographic Algorithm Self Test for FFDHE cipher suites.
@s-arash
Copy link
Collaborator Author

s-arash commented Feb 15, 2024

Not needed anymore, as FFDHE was upstreamed.

@s-arash s-arash closed this Feb 15, 2024
@s-arash
Copy link
Collaborator Author

s-arash commented Feb 15, 2024

Note: I should create a PR to merge ffdhe into master based on the upstream rustls.

@Taowyoo
Copy link
Collaborator

Taowyoo commented Feb 15, 2024

@s-arash , Yes, are you going to create PR recently?

@s-arash
Copy link
Collaborator Author

s-arash commented Feb 15, 2024

@Taowyoo on second thought, maybe we should wait for rustls to make a new release with ffdhe support included. Because if we do that now, we cannot target the crates.io rustls.

@Taowyoo
Copy link
Collaborator

Taowyoo commented Feb 15, 2024

Make sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants