Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meshgrid subroutine in stdlib_math #764

Merged
merged 7 commits into from
Mar 5, 2024
Merged

Conversation

igirault
Copy link
Contributor

WIP: first_proposal

The PR implements meshgrid, based on the API described in #18. It includes tests, spec and examples.

All versions for integer and real types are generated with fypp, as well as multi-dimensional versions, from 1 up to the maximum rank allowed.

The use of the subroutine error_stop in the case of invalid argument indexing prevented me to declare the subroutine with the pure attribute.

WIP: first_proposal
@igirault igirault changed the title meshgrid Add meshgrid subroutine in stdlib_math Jan 18, 2024
@igirault igirault changed the title Add meshgrid subroutine in stdlib_math Add meshgrid subroutine in stdlib_math Jan 18, 2024
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.
I am not familiar with this. However, the specs, code and tests seem to be good to me. I have only a few suggestions.

doc/specs/stdlib_math.md Outdated Show resolved Hide resolved
doc/specs/stdlib_math.md Show resolved Hide resolved
doc/specs/stdlib_math.md Outdated Show resolved Hide resolved
doc/specs/stdlib_math.md Outdated Show resolved Hide resolved
doc/specs/stdlib_math.md Outdated Show resolved Hide resolved
src/stdlib_math_meshgrid.fypp Outdated Show resolved Hide resolved
test/math/test_meshgrid.fypp Show resolved Hide resolved
@jvdp1 jvdp1 requested review from ivan-pi and a team February 8, 2024 21:38
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @Ivanou34 for this PR.

Copy link
Member

@perazz perazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you @Ivanou34

@jvdp1
Copy link
Member

jvdp1 commented Mar 5, 2024

Thank you @perazz for your review. I will fix the conflict ( in a CMake file) and merge it.
Thank you @Ivanou34 for this PR!

@jvdp1 jvdp1 merged commit 8476d65 into fortran-lang:master Mar 5, 2024
17 checks passed
@igirault igirault deleted the meshgrid branch April 16, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants