-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add meshgrid
subroutine in stdlib_math
#764
Conversation
WIP: first_proposal
meshgrid
subroutine in stdlib_math
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR.
I am not familiar with this. However, the specs, code and tests seem to be good to me. I have only a few suggestions.
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @Ivanou34 for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you @Ivanou34
Thank you @perazz for your review. I will fix the conflict ( in a CMake file) and merge it. |
WIP: first_proposal
The PR implements
meshgrid
, based on the API described in #18. It includes tests, spec and examples.All versions for
integer
andreal
types are generated with fypp, as well as multi-dimensional versions, from 1 up to the maximum rank allowed.The use of the subroutine
error_stop
in the case of invalid argumentindexing
prevented me to declare the subroutine with thepure
attribute.