Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds mcrypt extension for PHP 5.6.40 #340

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

nickkadutskyi
Copy link
Contributor

Adds missing mcrypt ext from php-src.

@nickkadutskyi
Copy link
Contributor Author

Fixes this issue #337

pkgs/package-overrides.nix Outdated Show resolved Hide resolved
pkgs/package-overrides.nix Outdated Show resolved Hide resolved
pkgs/package-overrides.nix Outdated Show resolved Hide resolved
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also when ready, please combine the changes into a single commit titled php56.extensions.mcrypt: init

@nickkadutskyi
Copy link
Contributor Author

Also when ready, please combine the changes into a single commit titled php56.extensions.mcrypt: init

Just force-pushed the squash

@jtojnar
Copy link
Member

jtojnar commented May 4, 2024

Looks like it also needs a check definition

nix-phps/checks.nix

Lines 32 to 36 in d40b1a1

mysql = {
description = "Build MySQL extension";
enabled = { php, lib, ... }: lib.versionOlder php.version "7";
drv = { php, ... }: php.extensions.mysql;
};

Adds check for mcrypt
@nickkadutskyi
Copy link
Contributor Author

Looks like it also needs a check definition

nix-phps/checks.nix

Lines 32 to 36 in d40b1a1

mysql = {
description = "Build MySQL extension";
enabled = { php, lib, ... }: lib.versionOlder php.version "7";
drv = { php, ... }: php.extensions.mysql;
};

Just add mcrypt into checks.

@jtojnar jtojnar merged commit 5c2a9bf into fossar:master Jul 11, 2024
31 checks passed
@jtojnar
Copy link
Member

jtojnar commented Jul 11, 2024

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants