Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake.lock: Update #367

Closed
wants to merge 1 commit into from
Closed

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 15, 2024

Automated changes by the update-flake-lock GitHub Action.

Flake lock file updates:

• Updated input 'flake-compat':
    'github:edolstra/flake-compat/0f9255e01c2351cc7d116c072cb317785dd33b33?narHash=sha256-kvjfFW7WAETZlt09AgDn1MrtKzP7t90Vf7vypd3OL1U%3D' (2023-10-04)
  → 'github:edolstra/flake-compat/9ed2ac151eada2306ca8c418ebd97807bb08f6ac?narHash=sha256-HRJ/18p%2BWoXpWJkcdsk9St5ZiukCqSDgbOGFa8Okehg%3D' (2024-11-27)
• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/9bb1e7571aadf31ddb4af77fc64b2d59580f9a39?narHash=sha256-Yd0FK9SkWy%2BZPuNqUgmVPXokxDgMJoGuNpMEtkfcf84%3D' (2024-09-05)
  → 'github:NixOS/nixpkgs/4703b8d2c708e13a8cab03d865f90973536dcdf5?narHash=sha256-B5pYT%2BIVaqcrfOekkwKvx/iToDnuQWzc2oyDxzzBDc4%3D' (2024-11-30)
• Updated input 'utils':
    'github:numtide/flake-utils/b1d9ab70662946ef0850d488da1c9019f3a9752a?narHash=sha256-SZ5L6eA7HJ/nmkzGG7/ISclqe6oZdOZTNoesiInkXPQ%3D' (2024-03-11)
  → 'github:numtide/flake-utils/11707dc2f618dd54ca8739b309ec4fc024de578b?narHash=sha256-l0KFg5HjrsfsO/JpG%2Br7fRrqm12kzFHyUHqHCVpMMbI%3D' (2024-11-13)

Running GitHub Actions on this PR

GitHub Actions will not run workflows on pull requests which are opened by a GitHub Action.

To run GitHub Actions workflows on this PR, run:

git branch -D update_flake_lock_action
git fetch origin
git checkout update_flake_lock_action
git commit --amend --no-edit
git push origin update_flake_lock_action --force

@drupol drupol closed this Sep 15, 2024
@drupol drupol reopened this Sep 15, 2024
@github-actions github-actions bot force-pushed the update_flake_lock_action branch from 38e1fae to 0bc3461 Compare September 22, 2024 03:13
@drupol drupol closed this Sep 22, 2024
@drupol drupol reopened this Sep 22, 2024
@github-actions github-actions bot force-pushed the update_flake_lock_action branch 2 times, most recently from 030081c to 6d06462 Compare October 6, 2024 03:15
@jtojnar jtojnar closed this Oct 6, 2024
@jtojnar jtojnar reopened this Oct 6, 2024
@github-actions github-actions bot force-pushed the update_flake_lock_action branch from 6d06462 to 80f6961 Compare October 13, 2024 03:15
@github-actions github-actions bot force-pushed the update_flake_lock_action branch 2 times, most recently from 2cbfcb4 to 17d641b Compare October 27, 2024 03:16
@github-actions github-actions bot force-pushed the update_flake_lock_action branch from 17d641b to c2776fc Compare November 3, 2024 03:17
@drupol drupol closed this Nov 6, 2024
@drupol drupol reopened this Nov 6, 2024
@github-actions github-actions bot force-pushed the update_flake_lock_action branch 2 times, most recently from 607d0b0 to 05d3372 Compare November 11, 2024 20:50
@drupol drupol closed this Nov 11, 2024
@drupol drupol reopened this Nov 11, 2024
@drupol
Copy link
Collaborator

drupol commented Nov 11, 2024

@jtojnar Let's remove the file bug66112.phpt? Or you have a better idea to fix the PHP 7.{1,2,3} tests ?

@jtojnar
Copy link
Member

jtojnar commented Nov 11, 2024

Removing the test file on affected versions sounds good to me. Or even disable the tests if the former would be too much work. If someone cares about soap, they can try to fix it themselves.

@drupol
Copy link
Collaborator

drupol commented Nov 11, 2024

I think the issue would be fixed if we backport this patch: php/php-src@26dfce7

@jtojnar
Copy link
Member

jtojnar commented Nov 11, 2024

I do not see how that would help – I would expect dirname(__FILE__) to be equivalent to __DIR__ in all situations. But I will leave it up to you.

Unfortunately, I probably will not be able to do any substantial work on nix-phps anytime soon.

@github-actions github-actions bot force-pushed the update_flake_lock_action branch from 05d3372 to ffafa7f Compare November 17, 2024 03:22
@drupol drupol closed this Nov 17, 2024
@drupol drupol reopened this Nov 17, 2024
@github-actions github-actions bot force-pushed the update_flake_lock_action branch from ffafa7f to 63a79ec Compare November 24, 2024 03:23
@drupol drupol closed this Nov 24, 2024
@drupol drupol reopened this Nov 24, 2024
@drupol
Copy link
Collaborator

drupol commented Nov 24, 2024

I do not see how that would help – I would expect dirname(__FILE__) to be equivalent to __DIR__ in all situations. But I will leave it up to you.

You're right, my mistake.

@piotrkwiecinski Do you have an idea with the issues related to the build issues with PHP 7 on x86-Linux ? (I remember you did some work in loophp/php-src-nix)

@drupol
Copy link
Collaborator

drupol commented Nov 26, 2024

@piotrkwiecinski ^^

@piotrkwiecinski
Copy link
Contributor

@drupol I did for php 8.x. I won't have time to look at it before weekend. I have a lot of firefighting at work this week.

@drupol
Copy link
Collaborator

drupol commented Nov 28, 2024

Hope you'll get through this soon ! 💪

@piotrkwiecinski
Copy link
Contributor

I'm waiting for nixpkgs to include updated xdebug to unlock 8.4 and I'll create a PR. For now I'll remove the failing test files to unlock the flake.lock update.

I tried fetching a couple commits from 7.4 to 7.3 but they don't apply correctly.

Flake lock file updates:

• Updated input 'flake-compat':
    'github:edolstra/flake-compat/0f9255e01c2351cc7d116c072cb317785dd33b33?narHash=sha256-kvjfFW7WAETZlt09AgDn1MrtKzP7t90Vf7vypd3OL1U%3D' (2023-10-04)
  → 'github:edolstra/flake-compat/9ed2ac151eada2306ca8c418ebd97807bb08f6ac?narHash=sha256-HRJ/18p%2BWoXpWJkcdsk9St5ZiukCqSDgbOGFa8Okehg%3D' (2024-11-27)
• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/9bb1e7571aadf31ddb4af77fc64b2d59580f9a39?narHash=sha256-Yd0FK9SkWy%2BZPuNqUgmVPXokxDgMJoGuNpMEtkfcf84%3D' (2024-09-05)
  → 'github:NixOS/nixpkgs/4703b8d2c708e13a8cab03d865f90973536dcdf5?narHash=sha256-B5pYT%2BIVaqcrfOekkwKvx/iToDnuQWzc2oyDxzzBDc4%3D' (2024-11-30)
• Updated input 'utils':
    'github:numtide/flake-utils/b1d9ab70662946ef0850d488da1c9019f3a9752a?narHash=sha256-SZ5L6eA7HJ/nmkzGG7/ISclqe6oZdOZTNoesiInkXPQ%3D' (2024-03-11)
  → 'github:numtide/flake-utils/11707dc2f618dd54ca8739b309ec4fc024de578b?narHash=sha256-l0KFg5HjrsfsO/JpG%2Br7fRrqm12kzFHyUHqHCVpMMbI%3D' (2024-11-13)
@github-actions github-actions bot force-pushed the update_flake_lock_action branch from 63a79ec to affde28 Compare December 1, 2024 03:35
@drupol
Copy link
Collaborator

drupol commented Dec 1, 2024

Fixed by #382

@drupol drupol closed this Dec 1, 2024
@drupol drupol deleted the update_flake_lock_action branch December 1, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants