Sync commits from upstream

[lcduong]

Commit hash	Description
6cce68b6f01e5a36ef8611d6b0af02c86b1285dd	Release v1.3.1
4fd5506efe8c4bc193d1aac77502463394f3ad90	Update translations
0b3c2f676054915192813b8ddb94190b94b38d46	Remove duplicate error display
2c034f4759331e71bba1a9a3b4e123f9605dc7fe	Use correct non_field_errors approach
adf43beeca70ddb84adb22d93fe3f79329e62023	Remove django-bootstrap4
39042675345c9020b2e5282fe6e9691b75b34d78	Code style
306d0e108e8646901e6b76f5a4e3d025053d489a	Code style
ced07f95983abff5d72798930b4634aad5611cf0	Release v1.3.0
66a0ff98c85d83771eea70c3cb85b8f99695d095	Ignore celery results
20d05009383b4f5bc6cb62c47094e5446434d030	Make sure celery tasks have names

Summary by Sourcery

Sync with upstream changes, including a new release version 1.3.1, removal of django-bootstrap4, and improvements in code style. Fix handling of non_field_errors and update Celery task configurations to include names and ignore results.

New Features:

• Introduce version 1.3.1 of the project.

Bug Fixes:

• Correct the approach for handling non_field_errors.

Enhancements:

• Remove the django-bootstrap4 dependency from the project.
• Improve code style and formatting across multiple files.
• Ensure Celery tasks have explicit names and ignore results where applicable.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request syncs commits from upstream, including several code style improvements, removal of django-bootstrap4 dependency, updates to Celery task configurations, and minor adjustments to error handling and template rendering. The changes span across multiple files, focusing on improving code quality and updating dependencies.

Sequence diagram for task_refresh_upstream_schedule invocation

sequenceDiagram
    actor User
    participant View
    participant Task
    User->>View: Submit form with action 'refresh'
    View->>Task: task_refresh_upstream_schedule.apply_async(args=(event_slug,), ignore_result=True)
    Task-->>View: Schedule task
    View-->>User: Display success message

Loading

Class diagram for Celery task configuration changes

classDiagram
    class Task {
        +apply_async(args, kwargs)
    }
    class task_refresh_upstream_schedule {
        +apply_async(args, kwargs, ignore_result)
    }
    Task <|-- task_refresh_upstream_schedule
    note for task_refresh_upstream_schedule "Updated to include ignore_result parameter"

Loading

File-Level Changes

Change	Details	Files
Removed django-bootstrap4 dependency and updated template rendering	Removed {% load bootstrap4 %} from the template Replaced {% bootstrap_form form layout='event' %} with {{ form }} Simplified HTML structure in the template	pretalx_downstream/templates/pretalx_downstream/settings.html
Updated Celery task configurations	Added explicit task name to refresh_upstream_schedule task Added ignore_result=True to task_refresh_upstream_schedule.apply_async() calls	pretalx_downstream/tasks.py pretalx_downstream/management/commands/downstream_pull.py pretalx_downstream/views.py pretalx_downstream/signals.py
Improved error handling and code style	Updated XML parsing from ET.fromstring to ElementTree.fromstring Fixed string formatting for new_code generation Removed duplicate error display	pretalx_downstream/tasks.py
Updated version number	Changed version from 1.2.0 to 1.3.1	pretalx_downstream/__init__.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @lcduong - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider implementing more robust error handling and logging, especially for the task_refresh_upstream_schedule function. The current use of a generic Exception catch and ignore_result=True might hide important errors. A more specific exception handling strategy and a mechanism to log errors would improve the reliability and debuggability of the sync process.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}