-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidied up files #30
base: master
Are you sure you want to change the base?
Tidied up files #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@developess thanks this looks good, but I think some of the changes might conflict with the changes @mattlub made in #28 (specifically hoisting step-1 into root, but there may be others).
Happy to be advised by you both once you've coordinated on which PR to merge first.
dbConnection.query(`SELECT * FROM superheroes` | ||
, (err, res) => { | ||
const getData = cb => { | ||
dbConnection.query(`SELECT * FROM superheroes`, (err, res) => { | ||
if (err) cb(err); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This either needs to be an if/else
or there needs to be an early return in the if
statement, otherwise an error will cause the callback to execute twice. Let's double check the rest of the steps too to see if it crops up in any of them too.
Hi @developess, have you had a chance to see the PR #28? It doesn't change much but does some similar things to yours, but moving the starting code to the root directory, so students start coding from the root directory, and only need to look inside the steps folder for reference. |
@mattlub I didn't see it initially! I checked the issues but there was nothing about removing random files and imports. Happy for yours to be merged first and I'll see if there's anything left that I changed. |
@developess are there any outstanding changes you think need to be made? |
All the additions and changes here are explained in #29
Summary:
data.sql
handler.js
dynamic.js
inhandler.js
)Unforseen changes:
db_build.sql
files across steps - I amended them to be consistent with mentor notes.Closes #29