Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidied up files #30

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Tidied up files #30

wants to merge 5 commits into from

Conversation

developess
Copy link

All the additions and changes here are explained in #29

Summary:

  • Removed erroneous file data.sql
  • Removed superfluous import of http module in handler.js
  • Removed reference to file until it has been written in the codealong (dynamic.js in handler.js)
  • Removed duplicate step (1), reducing 5 steps to 4, renamed files
  • Amended mentor notes to be clearer and renamed steps

Unforseen changes:

  • In the process I noticed some inconsistencies in the db_build.sql files across steps - I amended them to be consistent with mentor notes.
  • Some minor changes as a result of linting all files.

Closes #29

Copy link
Member

@eliasmalik eliasmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@developess thanks this looks good, but I think some of the changes might conflict with the changes @mattlub made in #28 (specifically hoisting step-1 into root, but there may be others).

Happy to be advised by you both once you've coordinated on which PR to merge first.

dbConnection.query(`SELECT * FROM superheroes`
, (err, res) => {
const getData = cb => {
dbConnection.query(`SELECT * FROM superheroes`, (err, res) => {
if (err) cb(err);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This either needs to be an if/else or there needs to be an early return in the if statement, otherwise an error will cause the callback to execute twice. Let's double check the rest of the steps too to see if it crops up in any of them too.

@mattlub
Copy link
Contributor

mattlub commented Nov 29, 2018

Hi @developess, have you had a chance to see the PR #28? It doesn't change much but does some similar things to yours, but moving the starting code to the root directory, so students start coding from the root directory, and only need to look inside the steps folder for reference.

@developess
Copy link
Author

@mattlub I didn't see it initially! I checked the issues but there was nothing about removing random files and imports. Happy for yours to be merged first and I'll see if there's anything left that I changed.

@mattlub mattlub removed their assignment Dec 4, 2018
@arrested-developer
Copy link

@developess are there any outstanding changes you think need to be made?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants