-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add oe_builtin app note #799
base: main
Are you sure you want to change the base?
Conversation
Added to an existing admonition, and changed admonition type from "note" to "important". QA: Checked rendered output, no issues found. This commit addresses FFTK-1660, "…OE Apps must be validated…" Signed-off-by: Katrina Prosise <[email protected]>
@@ -70,6 +70,8 @@ making sure to set the appropriate values for ``app_type`` and ``oe_builtin`` (s | |||
|
|||
This option does not work with some advanced tagging cases, e.g. multiple container builds using the same platform (see :ref:`ref-advanced-tagging` for more details). | |||
|
|||
**The Apps must be validated and without conflict**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kprosise can you clarify what this means?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can try, though there isn't much more info recorded anywhere, but I will check with the Platform team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, I didn't understand what this means exactly, maybe it means that the apps and platform need to be aligned and verified before enabling container preloading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this use-case is meant by This option does not work with some advanced tagging cases, e.g. multiple container builds using the same platform
.
The OE builtin app preloading fails in such the case because there is an ambiguity in terms of which of the tags' apps to choose. For example, in the example provided in the doc the dilemma is: should be the apps of the main
branch preloaded or the foo
branch of the containers.git repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that, but not sure what "The Apps must be validated and without conflict" means in this context. Maybe we just remove this line as it's causing confusion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kprosise
Probably we just remove that phrase or replace it with something what I wrote above "The OE builtin app preloading fails in such the case because there is an ambiguity in terms of which of the tags' apps to choose..."?
Added to an existing admonition, and changed admonition type from "note" to "important".
QA: Checked rendered output, no issues found.
This commit addresses FFTK-1660, "…OE Apps must be validated…"
PR Template and Checklist
Please complete as much as possible to speed up the reviewing process.
Readiness and adding reviewers as appropriate is required.
All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.
Readiness
Overview
Older issue, but appears to still be applicable.
Checklist
make linkcheck
.-s, --signoff
).-S, --gpg-sign
).Comments
Kept message terse, and isn't something which would apply for most folks.