Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shell completions #2936

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Shell completions #2936

wants to merge 15 commits into from

Conversation

kkawula
Copy link
Member

@kkawula kkawula commented Feb 12, 2025 •
edited
Loading

Closes #2311

Introduced changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@kkawula kkawula marked this pull request as ready for review February 12, 2025 13:44
@kkawula kkawula requested a review from a team as a code owner February 12, 2025 13:44
franciszekjob
franciszekjob reviewed Feb 27, 2025
View reviewed changes
ddoktorski
ddoktorski reviewed Mar 3, 2025
View reviewed changes
Copy link
Contributor

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the issue linked in the description as it currently points to this PR

ddoktorski
ddoktorski approved these changes Mar 3, 2025
View reviewed changes
docs/src/appendix/snforge/completion.md
Generates a completion script for the specified shell and writes it to `stdout`.

## `[SHELL]`
Optional
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Actually there is no Optional/Required line for snforge commands in the docs, but it could be added.

franciszekjob
franciszekjob approved these changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 👌
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddoktorski ddoktorski ddoktorski approved these changes

@franciszekjob franciszekjob franciszekjob approved these changes

@cptartur cptartur Awaiting requested review from cptartur cptartur is a code owner automatically assigned from foundry-rs/starknet-foundry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shell completions
3 participants
@kkawula @ddoktorski @franciszekjob