Skip to content
This repository has been archived by the owner on Aug 13, 2022. It is now read-only.

Add drawing of workflow DAG #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add drawing of workflow DAG #5

wants to merge 4 commits into from

Conversation

mrwalker
Copy link

@mrwalker mrwalker commented Apr 5, 2013

From @abeppu, adds drawing of workflow DAG in d3. His comment on the initial commit:

this may look weird in d3, but I think the nice benefit is that we can (w/ a little work) do things like color according to status, have scroll-over info, etc.

@jgoulah
Copy link

jgoulah commented Apr 5, 2013

example:

Oozie _ oozie-web

@rathboma
Copy link
Contributor

rathboma commented May 6, 2013

Sorry it took so long for me to look at this.

Can we make the graph div hidden by default and add a 'reveal' button. Just thinking of the case where a workflow is pretty large.

Also, could you squish the commits into a single commit? Then I'll happily merge.

@jgoulah
Copy link

jgoulah commented May 6, 2013

yup, there is a big part of me that wants tabs on this page, where the job definition, and then graphs are both on separate tabs. both of those can get pretty big for us. maybe out of scope for this change set but any thoughts on that?

@rathboma
Copy link
Contributor

rathboma commented May 6, 2013

I'm definitely not opposed to tabs, I do like to find things on the page though, so wouldn't want to go crazy with the tabs.

Also agree that this is probably outside the scope of this changeset.

@jgoulah
Copy link

jgoulah commented Jun 4, 2013

redid this pull request here since you wanted everything squashed:

#6

@jgoulah
Copy link

jgoulah commented Nov 11, 2013

this should be closed, in favor of pull #7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants