Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comparison operators to Record class #44

Open
wants to merge 2 commits into
base: improve-index-support
Choose a base branch
from

Conversation

Schamper
Copy link
Member

@Schamper Schamper commented Jan 28, 2025

Closes #40

Depends on #36.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 56.41026% with 17 lines in your changes missing coverage. Please review.

Project coverage is 78.78%. Comparing base (70ae493) to head (669aa39).

Files with missing lines Patch % Lines
dissect/esedb/record.py 56.41% 17 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           improve-index-support      #44      +/-   ##
=========================================================
- Coverage                  79.10%   78.78%   -0.32%     
=========================================================
  Files                         16       16              
  Lines                       1407     1433      +26     
=========================================================
+ Hits                        1113     1129      +16     
- Misses                       294      304      +10     
Flag Coverage Δ
unittests 78.78% <56.41%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper force-pushed the improve-index-support branch from 01dec74 to 70ae493 Compare January 28, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant