Fix inconsistency of target.ips output #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSCU-CNI
changed the title
|
Hi @JSCU-CNI , please open an issue and attache this PR so we can schedule a review into our sprints. |
Schamper
requested changes
Oct 7, 2024
Co-authored-by: Erik Schamper <[email protected]>
Schamper
reviewed
Oct 7, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #870 +/- ##
==========================================
- Coverage 77.02% 77.01% -0.01%
==========================================
Files 322 322
Lines 27575 27566 -9
==========================================
- Hits 21239 21231 -8
+ Misses 6336 6335 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Couldn't figure out how to properly modify a VirtualHive in a way the RegistryPlugin registers multiple ControlSets. Perhaps you know of a better way @Schamper? |
|
We can further simplify the general network plugin when fox-it/flow.record#148 is merged. |
|
This is now ready for review. |
Schamper
requested changes
Oct 21, 2024
Co-authored-by: Erik Schamper <[email protected]>
Schamper
requested changes
Oct 25, 2024
Schamper
previously approved these changes
Oct 31, 2024
Schamper
approved these changes
Oct 31, 2024
wbi-ocd
added a commit
to wbi-ocd/dissect.target
that referenced
this pull request
Nov 20, 2024
Add optional params to _get_config_value to split value according to a list of character Regression added in fox-it#870
wbi-ocd
added a commit
to wbi-ocd/dissect.target
that referenced
this pull request
Nov 20, 2024
Add optional params to _get_config_value to split value according to a list of character Regression added in fox-it#870
wbi-ocd
added a commit
to wbi-ocd/dissect.target
that referenced
this pull request
Nov 20, 2024
Add optional params to _get_config_value to split value according to a list of character Regression added in fox-it#870
wbi-ocd
added a commit
to wbi-ocd/dissect.target
that referenced
this pull request
Nov 20, 2024
Add optional params to _get_config_value to split value according to a list of character Regression added in fox-it#870
wbi-ocd
added a commit
to wbi-ocd/dissect.target
that referenced
this pull request
Nov 20, 2024
Add optional params to _get_config_value to split value according to a list of character Regression added in fox-it#870
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #877.