Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AlignedStream readinto based #31

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

Schamper
Copy link
Member

@Schamper Schamper commented Jul 30, 2023

Mostly experimental for now and requires benchmarking and profiling to see it it's worth pursuing this further. In some initial tests this turns out to be slower, but that's probably also because the rest of the chain (all containers and Dissect implementations) will use the _read fallback.

Also looks like PyPy is not happy about using memoryview.

The goal of this PR is to have a branch with which further testing can be performed to see if this is worthwhile.

@Schamper Schamper marked this pull request as draft July 30, 2023 14:27
@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Attention: Patch coverage is 80.44693% with 35 lines in your changes missing coverage. Please review.

Project coverage is 83.66%. Comparing base (931f5ca) to head (43a0805).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
dissect/util/stream.py 80.44% 35 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   85.00%   83.66%   -1.35%     
==========================================
  Files          16       16              
  Lines        1107     1169      +62     
==========================================
+ Hits          941      978      +37     
- Misses        166      191      +25     
Flag Coverage Δ
unittests 83.66% <80.44%> (-1.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pyrco pyrco removed their request for review August 29, 2023 07:24
dissect/util/stream.py Outdated Show resolved Hide resolved
dissect/util/stream.py Show resolved Hide resolved
dissect/util/stream.py Show resolved Hide resolved
dissect/util/stream.py Outdated Show resolved Hide resolved
@Schamper Schamper force-pushed the alignedstream-readinto branch from 43a0805 to 671d802 Compare November 4, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants