Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve XLSX adapter #137

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Improve XLSX adapter #137

merged 2 commits into from
Sep 24, 2024

Conversation

JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Sep 5, 2024

This PR makes it easier to write records to an xlsx file. Each record descriptor gets its own sheet within the workbook and field values are sanitized to prevent openpyxl errors.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 31.94444% with 49 lines in your changes missing coverage. Please review.

Project coverage is 83.70%. Comparing base (b003b6c) to head (74e8a8d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
flow/record/adapter/xlsx.py 31.94% 49 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
- Coverage   83.90%   83.70%   -0.21%     
==========================================
  Files          34       34              
  Lines        3429     3485      +56     
==========================================
+ Hits         2877     2917      +40     
- Misses        552      568      +16     
Flag Coverage Δ
unittests 83.70% <31.94%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Horofic Horofic requested a review from yunzheng September 19, 2024 06:47
flow/record/adapter/xlsx.py Outdated Show resolved Hide resolved
tests/test_xlsx_adapter.py Outdated Show resolved Hide resolved
@JSCU-CNI
Copy link
Contributor Author

Good catch, thanks.

@yunzheng yunzheng force-pushed the improve-xlsx-adapter branch from 05b75c2 to 74e8a8d Compare September 24, 2024 11:29
@yunzheng yunzheng merged commit 1701dcf into fox-it:main Sep 24, 2024
17 of 19 checks passed
@JSCU-CNI JSCU-CNI deleted the improve-xlsx-adapter branch September 25, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants