Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show timezone warnings for UTC #141

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

yunzheng
Copy link
Member

UTC is the default and should not show any warnings as we can fallback to timezone.UTC.

Fixes #140

UTC is the default and should not show any warnings as we can fallback to timezone.UTC.

Fixes #140
@yunzheng yunzheng requested a review from Schamper September 24, 2024 08:10
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.90%. Comparing base (f5d1a70) to head (2c6c241).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #141   +/-   ##
=======================================
  Coverage   83.89%   83.90%           
=======================================
  Files          34       34           
  Lines        3428     3429    +1     
=======================================
+ Hits         2876     2877    +1     
  Misses        552      552           
Flag Coverage Δ
unittests 83.90% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yunzheng yunzheng merged commit b003b6c into main Sep 24, 2024
20 checks passed
@yunzheng yunzheng deleted the suppress-timezone-warnings-for-utc branch September 24, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserWarning: ZoneInfoNotFoundError('No time zone found with key UTC'), falling back to timezone.utc
2 participants