Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle more elastic exceptions #152

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Conversation

JSCU-CNI
Copy link
Contributor

This PR improves the exception handling we introduced in #150.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.87%. Comparing base (c482853) to head (460dcfd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
flow/record/adapter/elastic.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files          34       34           
  Lines        3478     3478           
=======================================
  Hits         2917     2917           
  Misses        561      561           
Flag Coverage Δ
unittests 83.87% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

flow/record/adapter/elastic.py Outdated Show resolved Hide resolved
@JSCU-CNI JSCU-CNI requested a review from Schamper November 27, 2024 12:41
flow/record/adapter/elastic.py Outdated Show resolved Hide resolved
@Schamper Schamper merged commit 135a7b8 into fox-it:main Nov 27, 2024
17 of 20 checks passed
@JSCU-CNI JSCU-CNI deleted the fix/elastic-exceptions branch November 28, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants