Allow struct to contain member with same name #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achim-k
approved these changes
Feb 12, 2024
| @@ -1,7 +1,7 @@ | |||
| // -*- jsonc -*- | |||
| { | |||
| "editor.codeActionsOnSave": { | |||
| "source.fixAll.eslint": true | |||
| "source.fixAll.eslint": "explicit" | |||
There was a problem hiding this comment.
it's from a vscode update that hasn't gone through yet for this repo. studio has this as well.
jtbandes
approved these changes
Feb 12, 2024
Co-authored-by: Jacob Bandes-Storch <[email protected]>
snosenzo
deleted the
sam/fg-6541-parsing-failure-when-struct-member-and-struct-have-the-same
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to IDL spec, structs members consist of declarators rather than scoped names. So it's okay for them to have the same name because the struct member identifiers do not exist outside of the struct scope.
This also mirrors C behavior: https://stackoverflow.com/questions/15397502/in-c-can-struct-members-use-the-same-name-as-a-type
Fixes: FG-6541 and #132