Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added base device tree source for audiomini #18

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

Added base device tree source for audiomini #18

wants to merge 5 commits into from

Conversation

fe-wickham
Copy link
Member

Additionally added Makefile for easily building it and Jenkinsfiles so that Jenkins automatically builds the dtb files on update

@fe-wickham fe-wickham marked this pull request as draft January 8, 2021 18:08
@tvannoy
Copy link
Member

tvannoy commented Jan 8, 2021

Where did this dts come from? I think it is better to use the dts that is in the kernel source tree, as that is guaranteed to be based upon the base device tree created by Intel; doing so also guarantees that we get any bug fixes that Intel makes. Plus, there is already a framework for creating dtbs.

On the other hand, keeping our dts sources out-of-tree does perhaps make updating kernel versions easier.

@fe-wickham
Copy link
Member Author

Where did this dts come from?

Passthrough project here

I think it is better to use the dts that is in the kernel source tree, as that is guaranteed to be based upon the base device tree created by Intel; doing so also guarantees that we get any bug fixes that Intel makes. Plus, there is already a framework for creating dtbs.

I mostly agree. Thats part of why this is just a draft PR, because if I get around to updating this to use the dts from the kernel source this isn't needed but I'd rather have this than nothing.

On the other hand, keeping our dts sources out-of-tree does perhaps make updating kernel versions easier.

Does this really impact the kernel versions much? We may need to make sure we move any custom dts changes to the new branch I suppose but otherwise it shouldn't have much of an impact.

@tvannoy
Copy link
Member

tvannoy commented Jan 8, 2021

Yeah, it's best to at least have something.

Does this really impact the kernel versions much? We may need to make sure we move any custom dts changes to the new branch I suppose but otherwise it shouldn't have much of an impact.

Not really. There's not really any dependencies between the dts and the kernel version (unless of course a breaking change in the device tree subsystem was introduced, but that's unlikely). The small benefit is that updating to a new branch is easier if we don't have any commits that aren't upstream. But the benefit is quite small, as cherry-picking our handful of commits is not very difficult, and we can always just copy/paste files and lose our small commit history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants