Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Pydantic validate_arguments, and add first version of JSON Schemas #369

Merged
merged 32 commits into from
Jun 5, 2023
Merged

Use Pydantic validate_arguments, and add first version of JSON Schemas #369

merged 32 commits into from
Jun 5, 2023

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Apr 20, 2023 •
edited
Loading

@tcompa tcompa linked an issue Apr 20, 2023 that may be closed by this pull request
Test match between function arguments and pydantic model #368
Closed
@github-actions
Copy link

github-actions bot commented Apr 20, 2023 •
edited
Loading

Coverage report

The coverage rate went from 78.74% to 81.56% ⬆️
The branch rate is 75%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

@tcompa tcompa mentioned this pull request May 22, 2023
Closed
tcompa added 13 commits May 23, 2023 08:51
@tcompa
Add blank newline at the end of JSON-schema files
2a89cf0
@tcompa
Fix TaskArguments for cellpose_segmentation (close #372)
c4a89a3
@tcompa
Merge branch 'main' into 368-test-match-between-function-arguments-an…
705f9ae 
…d-pydantic-model
@tcompa
Merge branch 'main' into 368-test-match-between-function-arguments-an…
d38629a 
…d-pydantic-model
@tcompa
Update pydantic patch version in poetry.lock
b240955
@tcompa
Fix wrong field name in create_ome_zarr_multiplex.TaskArguments (close
6740ec8 
 #376)
@tcompa
Update JSON schema
b41ae85
@tcompa
Collect args_schema files in subfolder
0e2c176
@tcompa
Move args_schema attributes into manifest
54a1881
@tcompa
Remove fractal_tasks_core/__args_schema__ folder
7ab4856
@tcompa
Update test_valid_args_schemas.py, and add test_args_schema_comply_wi…
a3ccae9 
…th_jsonschema_specs
@tcompa
Rename has_args_schema into has_args_schemas, in manifest
326d481
@tcompa
Add test_has_args_schemas_is_true
e8a582c
@tcompa tcompa mentioned this pull request May 30, 2023
Closed
tcompa added 2 commits May 30, 2023 11:19
@tcompa
Update test_valid_args_schemas.py
5ba0782
@tcompa
Revamp argument validation (ref #377)
87a38b5 
* Use PydanticV1 `validate_arguments` instead of creating
  `TaskArguments` models by hand.
* Update tests.
* Update `args_schema` script.
@tcompa tcompa changed the title WIP work on type hints, pydantic models, defaults, and possibly JSON schemas Work on type hints, pydantic models, defaults, and JSON schemas May 31, 2023
This was referenced May 31, 2023
Closed
Closed
@tcompa tcompa marked this pull request as ready for review June 5, 2023 10:42
@tcompa tcompa changed the title Work on type hints, pydantic models, defaults, and JSON schemas Use Pydantic validate_arguments, and add first version of JSON Schemas Jun 5, 2023
@tcompa tcompa merged commit 6d13319 into main Jun 5, 2023
@tcompa tcompa deleted the 368-test-match-between-function-arguments-and-pydantic-model branch June 5, 2023 11:38
@tcompa tcompa mentioned this pull request Jun 5, 2023
Closed
This was referenced Jul 7, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@tcompa