-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace generic hermit crab icon with oasis emoji as app icon #10
base: master
Are you sure you want to change the base?
Conversation
This looks great! My only concern: what font is that, and is it open source? I think we'd be safe to use Noto Emoji, because I know it has an open license, but I'm not sure about other fonts. |
Good question! It's Noto Emoji. |
Sweet! LGTM. |
Hmm, it looks like it's failing on the ICNS: https://travis-ci.com/github/fraction/oasis-desktop/jobs/328239556 I don't know why that would be. |
hmm... yeah I found ICNS conversion to be super finicky. It took me a few tries to generate a file that wasn't corrupt. Let me try again. How does this process work? Do I make another PR? |
You can just push another commit to this branch and it'll re-run! |
argh, it's still failing. I guess I'll have to read up a bit more about .icns and how to properly create one. |
No description provided.