Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace generic hermit crab icon with oasis emoji as app icon #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aadilayub
Copy link

No description provided.

@christianbundy
Copy link
Member

This looks great! My only concern: what font is that, and is it open source? I think we'd be safe to use Noto Emoji, because I know it has an open license, but I'm not sure about other fonts.

@aadilayub
Copy link
Author

This looks great! My only concern: what font is that, and is it open source? I think we'd be safe to use Noto Emoji, because I know it has an open license, but I'm not sure about other fonts.

Good question! It's Noto Emoji.

@christianbundy
Copy link
Member

Sweet! LGTM.

@christianbundy
Copy link
Member

Hmm, it looks like it's failing on the ICNS: https://travis-ci.com/github/fraction/oasis-desktop/jobs/328239556

I don't know why that would be.

@aadilayub
Copy link
Author

aadilayub commented May 5, 2020

hmm... yeah I found ICNS conversion to be super finicky. It took me a few tries to generate a file that wasn't corrupt. Let me try again. How does this process work? Do I make another PR?

@christianbundy
Copy link
Member

You can just push another commit to this branch and it'll re-run!

@aadilayub
Copy link
Author

argh, it's still failing. I guess I'll have to read up a bit more about .icns and how to properly create one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants