Some refacts #11
Open
Some refacts #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillemfondin
commented
Jan 20, 2022
guillemfondin
commented
- clean some code
- fix expo warning (rollback @react-native-picker/picker from 2.2.1 to 2.1.0, and up react-native to 0.64.3)
- Add .gitignore
…er from 2.2.1 to 2.1.0, and up react-native to 0.64.3)
|
Duplicate of #5 ? |
|
In the idea sure, but I think most changes are differents |
Open
| @@ -134,7 +134,7 @@ export default function CandidateProfile({ route }) { | |||
| }} | |||
| onPress={() => | |||
| navigation.navigate("ThemeByCandidate", { | |||
| idCandidat: IDCandidat, | |||
| idCandidat: IDCandidate, | |||
There was a problem hiding this comment.
We should rename the key ? To make uniform "idcandidate"
There was a problem hiding this comment.
Yes I think also, but it needs to change it everywhere on the app, and I'm running out of time for now...
WebMamba
approved these changes
Jan 22, 2022
cadesalaberry
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.