fix: Selection on undo

frappe · Jan 18, 2024 · ad5c246 · ad5c246
1 parent bfca191
commit ad5c246
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 23 deletions.
diff --git a/frontend/src/components/BuilderBlock.vue b/frontend/src/components/BuilderBlock.vue
@@ -252,28 +252,30 @@ const showBlock = computed(() => {
 	return data;
 });
 
-watch(
-	() => store.hoveredBlock,
-	(newValue, oldValue) => {
-		if (newValue === props.block.blockId) {
-			isHovered.value = true;
-		} else if (oldValue === props.block.blockId) {
-			isHovered.value = false;
+if (!props.preview) {
+	watch(
+		() => store.hoveredBlock,
+		(newValue, oldValue) => {
+			if (newValue === props.block.blockId) {
+				isHovered.value = true;
+			} else if (oldValue === props.block.blockId) {
+				isHovered.value = false;
+			}
 		}
-	}
-);
-
-watch(
-	() => store.activeCanvas?.selectedBlockIds,
-	() => {
-		if (store.activeCanvas?.isSelected(props.block)) {
-			isSelected.value = true;
-		} else {
-			isSelected.value = false;
+	);
+	watch(
+		() => store.activeCanvas?.selectedBlockIds,
+		() => {
+			if (store.activeCanvas?.isSelected(props.block)) {
+				isSelected.value = true;
+			} else {
+				isSelected.value = false;
+			}
+		},
+		{
+			deep: true,
+			immediate: true,
 		}
-	},
-	{
-		deep: true,
-	}
-);
+	);
+}
 </script>
diff --git a/frontend/src/components/BuilderCanvas.vue b/frontend/src/components/BuilderCanvas.vue
@@ -472,7 +472,7 @@ const setRootBlock = (newBlock: Block, resetCanvas = false) => {
 
 const selectedBlockIds = ref([]) as Ref<string[]>;
 const selectedBlocks = computed(() => {
-	return selectedBlockIds.value.map((id) => findBlock(id));
+	return selectedBlockIds.value.map((id) => findBlock(id)).filter((b) => b) as Block[];
 }) as Ref<Block[]>;
 
 const isSelected = (block: Block) => {