fix: remove tds account in taxes table on change of Tax Withholding C… #45590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruthra-kumar
approved these changes
Feb 5, 2025
ruthra-kumar
added a commit
that referenced
this pull request
Feb 5, 2025
…-45590 fix: remove tds account in taxes table on change of Tax Withholding C… (backport #45590)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: On changing the Tax Withholding Category, the account in the taxes table is not being removed and continues to accumulate.
Solution: Added a JS validation on the change of Tax Withholding Category
Before:
tax_withholding_category_removal_before.webm
After:
tax_withholding_category_removal_after.webm
Backport needed: Version15