-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added ability to use custom html format for process statement of accounts #45746
Merged
ruthra-kumar
merged 3 commits into
frappe:version-14-hotfix
from
stevewilson9009:process_soa_custom_print_format
Feb 19, 2025
Merged
feat: added ability to use custom html format for process statement of accounts #45746
ruthra-kumar
merged 3 commits into
frappe:version-14-hotfix
from
stevewilson9009:process_soa_custom_print_format
Feb 19, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of accounts documents.
erpnext/accounts/doctype/process_statement_of_accounts/process_statement_of_accounts.py
Outdated
Show resolved
Hide resolved
Could you please review my code? |
@mergify copy develop |
✅ Pull request copies have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
…f accounts (#45746) * feat: added ability to use custom print format for process statement of accounts documents. * fix: handles missing hook issues * chore: linter changes --------- Co-authored-by: Boy4099 <[email protected]> Co-authored-by: ruthra kumar <[email protected]> (cherry picked from commit a0cd08e)
@mergify copy version-15-hotfix |
✅ Pull request copies have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
…f accounts (#45746) * feat: added ability to use custom print format for process statement of accounts documents. * fix: handles missing hook issues * chore: linter changes --------- Co-authored-by: Boy4099 <[email protected]> Co-authored-by: ruthra kumar <[email protected]> (cherry picked from commit a0cd08e)
ruthra-kumar
pushed a commit
that referenced
this pull request
Feb 19, 2025
…f accounts (copy #45746) (#46011) feat: added ability to use custom html format for process statement of accounts (#45746) * feat: added ability to use custom print format for process statement of accounts documents. * fix: handles missing hook issues * chore: linter changes --------- Co-authored-by: Boy4099 <[email protected]> Co-authored-by: ruthra kumar <[email protected]> (cherry picked from commit a0cd08e) Co-authored-by: Steve Wilson <[email protected]>
ruthra-kumar
pushed a commit
that referenced
this pull request
Feb 19, 2025
…f accounts (copy #45746) (#46012) feat: added ability to use custom html format for process statement of accounts (#45746) * feat: added ability to use custom print format for process statement of accounts documents. * fix: handles missing hook issues * chore: linter changes --------- Co-authored-by: Boy4099 <[email protected]> Co-authored-by: ruthra kumar <[email protected]> (cherry picked from commit a0cd08e) Co-authored-by: Steve Wilson <[email protected]>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
# [14.83.0](v14.82.2...v14.83.0) (2025-02-19) ### Bug Fixes * '0' rate LDC's Invoice net totals should be ignored (backport [#45639](#45639)) ([#45783](#45783)) ([534b25c](534b25c)) * add is_new in if condition ([ef37388](ef37388)) * fetch child account data for selected parent ([#45904](#45904)) ([e7d9786](e7d9786)) * include missing payment_gateway parameter in Payment Request URL ([a344b8b](a344b8b)) * millisecond issue for posting datetime ([fc6f568](fc6f568)) * on selection of batch qty is not fetching ([44a16bb](44a16bb)) * pos return validation on v14 ([#45859](#45859)) ([84432fc](84432fc)) * **report:** add options to multiselectlist fields ([aa0ada9](aa0ada9)) * **send_message:** escape HTML in the text ([703fd81](703fd81)) * serial no is mandatory for zero qty validation ([6f6133f](6f6133f)) * set default value to 0 as per new logic ([4b16272](4b16272)) * tests ([e515b91](e515b91)) ### Features * added ability to use custom html format for process statement of accounts ([#45746](#45746)) ([a0cd08e](a0cd08e)) * added option to enforce free item qty in pricing rule ([2edf083](2edf083))
🎉 This PR is included in version 14.83.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
frappe-pr-bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
# [15.53.0](v15.52.0...v15.53.0) (2025-02-19) ### Bug Fixes * add accounting dimensions section in sales order item ([b32e4da](b32e4da)) * add is_new in if condition ([fc2ec7c](fc2ec7c)) * add validate to allow equity account and party_type shareholder ([bb3eb81](bb3eb81)) * allow scrap item with zero qty ([abe5384](abe5384)) * auto create asset due to message error (backport [#45934](#45934)) ([#45952](#45952)) ([830edb8](830edb8)) * check if employee is currently working on another workstation ([22eaa14](22eaa14)) * disable partial payment in pos (backport [#45752](#45752)) ([#45945](#45945)) ([38edc46](38edc46)) * do not reschedule depreciation for fully depreciated asset on scrap ([1e7c5ec](1e7c5ec)) * fetch child account data for selected parent ([#45904](#45904)) ([e36b860](e36b860)) * handle division by zero error (backport [#45966](#45966)) ([#46015](#46015)) ([15106b4](15106b4)) * include missing payment_gateway parameter in Payment Request URL ([18f9476](18f9476)) * letter head for quality inspection ([c289fef](c289fef)) * link correct row item of purchase doc ([87f337b](87f337b)) * make purchase_receipt_item and purchase_invoice_item fields of data type ([281431e](281431e)) * millisecond issue for posting datetime ([4292365](4292365)) * patch for creating asset depreciation schedule records ([f043b46](f043b46)) * pos accounting dimension fieldname error (backport [#45899](#45899)) ([#45921](#45921)) ([e998f06](e998f06)) * **pos profile:** check company while validating mandatory accounting dimension ([#45974](#45974)) ([6a57743](6a57743)) * pos return validation on v15 ([#45951](#45951)) ([dd34bbe](dd34bbe)) * provision to enable naming series for SABB ([8fbfe14](8fbfe14)) * **quotation:** fetch exchange rate on currency change ([bd89c19](bd89c19)) * remove party type from validate ([0d21151](0d21151)) * remove public access to list items (backport [#45838](#45838)) ([#46018](#46018)) ([eead6d4](eead6d4)) * remove unused code ([dd5d144](dd5d144)) * **report:** add options to multiselectlist fields ([7e85a12](7e85a12)) * reset location only if there is value in row item location field ([a509568](a509568)) * resolved conflicts ([84647a1](84647a1)) * round sum amount in JE auditing PF ([#45961](#45961)) ([44e1ca9](44e1ca9)) * **send_message:** escape HTML in the text ([cbec989](cbec989)) * serial no status for internal transfer delivery note ([2b80c00](2b80c00)) * set default value to 0 as per new logic ([1abe1a1](1abe1a1)) * set sco_qty field of PO to non negative ([567fb8a](567fb8a)) * slow query ([8306d6f](8306d6f)) * stock reservation for sales invoice ([1fb5586](1fb5586)) * stock reservation not working for sales invoice with update stock ([7d871f6](7d871f6)) * tests ([f63a9db](f63a9db)) * throw correct exception ([5bccf9f](5bccf9f)) * validate if no matching item found ([6183b38](6183b38)) * validate payment request total of partly paid invoice ([c8881a9](c8881a9)) ### Features * added ability to use custom html format for process statement of accounts (copy [#45746](#45746)) ([#46012](#46012)) ([1a4297a](1a4297a)) * added option to enforce free item qty in pricing rule ([8fb9228](8fb9228)) * disable auto setting grand total to default mode of payment (backport [#45591](#45591)) ([#45917](#45917)) ([e271a5c](e271a5c))
Bhavan23
pushed a commit
to aerele/erpnext
that referenced
this pull request
Feb 20, 2025
…f accounts (copy frappe#45746) (frappe#46011) feat: added ability to use custom html format for process statement of accounts (frappe#45746) * feat: added ability to use custom print format for process statement of accounts documents. * fix: handles missing hook issues * chore: linter changes --------- Co-authored-by: Boy4099 <[email protected]> Co-authored-by: ruthra kumar <[email protected]> (cherry picked from commit a0cd08e) Co-authored-by: Steve Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to process_statement_of_accounts.py.
The added code accepts the path to a custom html format of General Ledger and Accounts Receivable through a hook.
This path to custom html format is then used to build pdf to either download or send email.
no-docs