Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always include discussion title and project in listing #344

Closed
wants to merge 1 commit into from
Closed

fix: always include discussion title and project in listing #344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions frontend/src/components/DiscussionList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,12 @@
<span :class="filters ? '' : 'hidden sm:inline'">
{{ user.full_name }}
</span>
<template v-if="!filters || !filters.project">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added so that project name is not visible if discussion list is being viewed inside project.
For e.g., /g/all-hands/projects/12/discussions/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are passing list of active projects to exclude discussions from archived projects on the discussions page. This condition is preventing display of the respective project names. Can it be passed as a prop instead, like displayProject?

<span> in </span>
<span>
{{ d.team_title }}
<span class="text-gray-500"> &mdash; </span>
{{ d.project_title }}
</span>
</template>
<span> in </span>
<span>
{{ d.team_title }}
<span class="text-gray-500"> &mdash; </span>
{{ d.project_title }}
</span>
</div>
</div>
</div>
Expand Down Expand Up @@ -200,4 +198,4 @@ export default {
this.$resources.discussions.reload()
},
}
</script>
</script>
Loading