-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Private sharing Support #428
Open
nagarjun063
wants to merge
17
commits into
frappe:develop
Choose a base branch
from
nagarjun063:private_sharing
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling an option to share securely using authentication via JWT
jwt endpoint created at generate_embed_link , can access using the following payload:
payload = {
"resource" : "your_site/insights/secure/dashboard/dashboard_name", // Generated by system
"params": { "column_name": 'value' }, // Filters
"user" : "session_user", // User to be part of system, else jwt token will not be generated
"exp": round(time.time()) + (60 * (int(10))) // Token valid for 10 Mins
}
added options to share either as public or securely as private, also validations for the same
insights/secure/dashboard view to support the authenticated link
added a field secret_key in Insights Settings for the authentication process