Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Proper Placement of Loan tab in Company DocType #229

Conversation

agatho-daemon
Copy link
Contributor

@agatho-daemon agatho-daemon commented Jan 10, 2025

Custom Loan tab is added to Company DocType. However, it is misplaced causing the fields in Stock and Manufacturing tab be split and attached to the Loan tab.

The placement is done in after_install hook pointing to lending.install file.

The insert_after key value should be the last field in Stock and Manufacturing which is '_ default_operating_cost_account_'

This will put back the Stock and Manufacturing fields back into there proper place.

Screenshot after running:
from lending.install import after_install
afteer_install()

CleanShot 2025-01-16 at 07 55 07@2x

@deepeshgarg007 deepeshgarg007 merged commit 7844cfc into frappe:develop Feb 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants