Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: LMS Batch Enrollment to store batch students #1296

Merged
merged 3 commits into from
Feb 10, 2025
Merged

refactor: LMS Batch Enrollment to store batch students #1296

merged 3 commits into from
Feb 10, 2025

Conversation

pateljannat
Copy link
Collaborator

  1. Batch Students were previously stored in a child table.
  2. There will now be stored in a DocType called LMS Batch Enrollment.

@cypress Cypress
Copy link

cypress bot commented Feb 10, 2025 •
edited
Loading

lms    Run #1033

Run Properties:  status check passed Passed #1033  •  git commit 0940979e0e ℹ️: Merge 8857ce81462596f77456a814a1e5fc76880cfe4b into bfbc5f600f7f45634d5fa44f6f9d...
Project lms
Branch Review batch-students-refactor
Run status status check passed Passed #1033
Run duration 00m 29s
Commit git commit 0940979e0e ℹ️: Merge 8857ce81462596f77456a814a1e5fc76880cfe4b into bfbc5f600f7f45634d5fa44f6f9d...
Committer Jannat Patel
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@pateljannat pateljannat merged commit b5a7b4c into frappe:develop Feb 10, 2025
5 checks passed
@pateljannat pateljannat mentioned this pull request Feb 10, 2025
Closed
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 2.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pateljannat @frappe-pr-bot