Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: misc batch flow changes #1304

Merged
merged 3 commits into from
Feb 12, 2025
Merged

fix: misc batch flow changes #1304

merged 3 commits into from
Feb 12, 2025

Conversation

pateljannat
Copy link
Collaborator

  1. Announcement Modal now has a fixed editor.
Screenshot 2025-02-12 at 12 47 45 PM
  1. Instructors will now see a Certification count on their batch dashboard.
Screenshot 2025-02-12 at 12 48 28 PM
  1. Linked LMS Certificate Evaluation and LMS Certificate to LMS Batch doctype.
  2. During assignments, if students uploaded one file and later wanted to change another, the old file was still being maintained after saving. Fixed that.

@cypress Cypress
Copy link

cypress bot commented Feb 12, 2025 •
edited
Loading

lms    Run #1047

Run Properties:  status check passed Passed #1047  •  git commit 898dfd05c2 ℹ️: Merge f63d57c4a9224aaf0a81f4943556e45c475159e4 into 451a151ce0f7f004f6d1cc0a44bc...
Project lms
Branch Review issues-74
Run status status check passed Passed #1047
Run duration 00m 29s
Commit git commit 898dfd05c2 ℹ️: Merge f63d57c4a9224aaf0a81f4943556e45c475159e4 into 451a151ce0f7f004f6d1cc0a44bc...
Committer Jannat Patel
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@pateljannat pateljannat merged commit e2f999f into frappe:develop Feb 12, 2025
5 checks passed
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 2.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pateljannat @frappe-pr-bot