fix: fixed bug in which user can submit quiz over the maximum limit allowed #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was causing this error
✘ [ERROR] Cannot assign to "isLoggedIn" because it is a constant
src/router.js:230:2:
230 │ isLoggedIn = false
╵ ~~~~~~~~~~
The symbol "isLoggedIn" was declared a constant here:
src/router.js:222:7:
222 │ const { isLoggedIn } = sessionStore()
╵ ^
…owing user to submit quiz multiple times
…til page reload ListView throws error if initialized without emptyState which was causing the component to not reload when number of submissions was 0.
lms
|
||||||||||||||||||||||||||||||
| Project |
lms
|
| Branch Review |
fix/quiz-maximum-attempts
|
| Run status |
|
| Run duration | 00m 29s |
| Commit |
|
| Committer | Fahid Latheef A |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
1
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
|
Fixes #1314 Case1 Fix maximum_attempts_bypass_method_1_after.mp4Case2 Fix maximum_attempts_bypass_method_2_after.mp4 |
pateljannat
reviewed
Feb 17, 2025
| @@ -219,7 +219,7 @@ let router = createRouter({ | |||
|
|
|||
| router.beforeEach(async (to, from, next) => { | |||
| const { userResource } = usersStore() | |||
| const { isLoggedIn } = sessionStore() | |||
| let { isLoggedIn } = sessionStore() | |||
There was a problem hiding this comment.
@FahidLatheef why this change?
There was a problem hiding this comment.
yarn dev is causing below error
✘ [ERROR] Cannot assign to "isLoggedIn" because it is a constant
src/router.js:230:2:
230 │ isLoggedIn = false
╵ ~~~~~~~~~~
The symbol "isLoggedIn" was declared a constant here:
src/router.js:222:7:
222 │ const { isLoggedIn } = sessionStore()
╵ ^
|
🎉 This PR is included in version 2.23.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes
Closes #1314