Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(batch): track active tab in URL/route #1337

Merged
merged 3 commits into from
Feb 22, 2025
Merged

Conversation

NagariaHussain
Copy link
Member

@NagariaHussain NagariaHussain commented Feb 22, 2025

Now if the instructor (or the student) goes somewhere from the dashboard or refreshes the page, they land back on the same tab they left from!

@NagariaHussain NagariaHussain changed the title feat: track active tab in URL/route feat(batch): track active tab in URL/route Feb 22, 2025
Copy link

cypress bot commented Feb 22, 2025

lms    Run #1099

Run Properties:  status check passed Passed #1099  •  git commit f60fab122c ℹ️: Merge 5a94e8df754cf3e561e5e68fa65e3a5443bb9c8e into 0678def698c3f7c146470ac35f7b...
Project lms
Branch Review batch-tabs
Run status status check passed Passed #1099
Run duration 00m 29s
Commit git commit f60fab122c ℹ️: Merge 5a94e8df754cf3e561e5e68fa65e3a5443bb9c8e into 0678def698c3f7c146470ac35f7b...
Committer Md Hussain Nagaria
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

@NagariaHussain NagariaHussain merged commit 95255d4 into develop Feb 22, 2025
5 checks passed
@NagariaHussain NagariaHussain deleted the batch-tabs branch February 22, 2025 17:00
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 2.24.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants