feat(volumes): Resize (shrink) EBS volumes #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on Virtual Machine Migration and Agent Update
New volume should be ~85% full after copying files
On single volume machines we assumed operations on volumes[0]. This is no longer true on machine with data volumes.
Since we'll be copying data after taking down everything. We want to copy data as fast as possible. gp3 allows max throughput of 1000 MB/s. EBS tries to merge sequential read / writes to 256KB blocks. So best case IOPS scenario is (1000 MB/s) / (256KB) = 4000 iops. We'll allow 20% buffer for inefficiencies. Reference: https://docs.aws.amazon.com/ebs/latest/userguide/ebs-io-characteristics.html TODO: Adjust these numbers based on actual results.
Remove filesystem and volume child tables. Track before and after status of the filesystem and volume in specific fields This assumes that each volume will have only one filesystem.
Collect UUID of new volume from output of mkfs
Unmount both volumes Replace UUID of old filesystem with new
Unmount both volumes Replace UUID of old filesystem with new
Reduce performance of new volume (This should work since we haven't made any modification after creating the volume) Delete old volume (We already have a snapshot of this volume)
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (1.87%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #2466 +/- ##
==========================================
- Coverage 37.32% 36.91% -0.41%
==========================================
Files 402 403 +1
Lines 31665 32029 +364
==========================================
+ Hits 11818 11823 +5
- Misses 19847 20206 +359 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EBS volume cannot be shrunk, only extended. One way to work around this restriction is to copy data to a new (smaller) volume and throw away the old (larger) volume.
This tool automates that procedure.
The maximum possible IO performance on EBS (gp3)
fiocan read/write at this throughput, with--ioengine=libaio,--bs=256kand--iodepth=8. Butcpcan barely manage ~250 MB/s.I'll need to find faster ways, I'm considering
dd(withskipandcount) and copy the partition as is