fix: wrong uri format in location header #144
Conversation
|
Hi @Alonza0314 , From #71 ,
Do we need to change the other NF's code? |
Yes, I have told amf to modify in r17.👍 |
Alonza0314
force-pushed
the
fix/api-smcontext-reply-hdr-location-format
branch
from
6d1c92b to
3b8b2b4
Compare
Alonza0314
force-pushed
the
fix/api-smcontext-reply-hdr-location-format
branch
from
3b8b2b4 to
a1d09e2
Compare
|
LGTM. |
| protocol, | ||
| c.Request.Host, | ||
| strings.TrimSuffix(c.Request.URL.Path, "/"), | ||
| strings.Split(smContext.Ref, ":")[2]) |
There was a problem hiding this comment.
Should add the length check to avoid the invalid memory access.
There was a problem hiding this comment.
I think this check appears to be redundant for two reasons:
- During UUID creation, the Must() function already ensures its validity by panicking if the creation fails.
- In the formatting part, the code:
copy(buf[:], "urn:uuid:")
encodeHex(buf[9:], uuid)guarantees that the format will always be urn:uuid:xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx.
Therefore, an additional length check at here is unnecessary as the format is enforced by the implementation itself.
By the way, I still can add a double check at here. Do you think we need it?😆
This PR fix the problem in issue #71.
Before:
After:
