Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/profile #114

Merged
merged 28 commits into from
Nov 12, 2024
Merged

feat/profile #114

merged 28 commits into from
Nov 12, 2024

Conversation

Alonza0314
Copy link
Contributor

Add new feature - profile

  • api schema (free5gc-Webconsole.postman_collection.json)
  • profile model (model_profile.go)

@Alonza0314 Alonza0314 changed the title Feat/profile Feat/profile-schema Oct 16, 2024
Copy link
Collaborator

@andy89923 andy89923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the profile of FlowRules.filter is too complicate, I think we can save the detination(w/wo port) only.

"FlowRules": [
        {
            "snssai": "01010203",
            "dnn": "internet",
            "filter": "permit out 17 from 192.168.0.0/24 8000 to 60.60.0.0/24 ",
            "qfi": 5
        }
    ],

The flow rules that saved in mongoDB:

{
  "_id": {
    "$oid": "66fa16cd912d361ab914446e"
  },
  "dnn": "internet",
  "qosRef": 1,
  "ueId": "imsi-208930000000001",
  "servingPlmnId": "20893",
  "filter": "1.1.1.1/32",
  "precedence": 128,
  "snssai": "01010203"
}

@Alonza0314 Alonza0314 changed the title Feat/profile-schema feat/profile Oct 24, 2024
andy89923
andy89923 previously approved these changes Oct 27, 2024
frontend/src/App.tsx Outdated Show resolved Hide resolved
…mponent, which used by profileRead and subscriberRead
@andy89923 andy89923 dismissed their stale review November 5, 2024 02:53

dismiss review

return
}
if len(pf) == 0 {
c.JSON(http.StatusNotFound, gin.H{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use models.problemDetails (from openapi pkg) to instead.

backend/WebUI/api_webui.go Outdated Show resolved Hide resolved
backend/WebUI/api_webui.go Show resolved Hide resolved
backend/WebUI/api_webui.go Outdated Show resolved Hide resolved
backend/WebUI/api_webui.go Outdated Show resolved Hide resolved
backend/WebUI/api_webui.go Outdated Show resolved Hide resolved
backend/WebUI/api_webui.go Outdated Show resolved Hide resolved
backend/WebUI/api_webui.go Outdated Show resolved Hide resolved
backend/WebUI/api_webui.go Outdated Show resolved Hide resolved
backend/WebUI/api_webui.go Outdated Show resolved Hide resolved
@ianchen0119 ianchen0119 merged commit cbc47fc into free5gc:main Nov 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants