Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/backend subscriber create #119

Merged
merged 30 commits into from
Nov 12, 2024
Merged

Refactor/backend subscriber create #119

merged 30 commits into from
Nov 12, 2024

Conversation

Alonza0314
Copy link
Contributor

Rewrite the error handle method under ueid already exists condition in subscriber create function

Alonza0314 and others added 30 commits November 1, 2024 14:55
@Alonza0314
feat: add profile api schema
7a9be0e
@Alonza0314
feat: add profile model
fb313a9
@Alonza0314
fix: rewrite the fileter example in flowrules
173a2ce
@Alonza0314
feat: add openapi generator docker script
8685fcb
@Alonza0314
feat: add backend profile api handler function and its corresponds ro…
f4932d5 
…uting method
@Alonza0314
feat: add a script for quickly compile frontend and run backend
13431ff
@Alonza0314
feat: add search box and pager in profile mlist page
c35d1d2
@Alonza0314
feat: add a selection box in subscriberCreate form
fa34f51
@Alonza0314
test: add a test file on profile DTO, and fix a small missing bugs on…
ec5da90 
… profile DTO implement
@Alonza0314
fix: solve the wrong profileName use in edit page(typo as name, shoul…
ef65d6e 
…d be profileName)
@Alonza0314
fix: solve golangci-lint problem
6677c96
@Alonza0314
fix: resolve govet shadowing issue by avoiding variable(err) re-decla…
c6fedfe 
…ration
@Alonza0314
feat: add tenantId into profileData, and set it as admin in default
fffae3a
@Alonza0314
refactor: add a blank line between import and function declaration
256568b
@Alonza0314
refactor: remove console.log and replace some error message from cons…
242306a 
…ole.log to "alert"
@Alonza0314
refactor: apply early return on flowRule and upSecurity function
fc72c1f
@Alonza0314
refactor: extract flowRule/upSecurity/chargingConfig as additional co…
458309a 
…mponent, which used by profileRead and subscriberRead
@yccodr
refactor: add a blank line between import and function declaration
bff83f8
@yccodr
chore: format
e2a693f
@yccodr
chore: format
6d6a95b
@yccodr
feat: show more friendly ui when error occurs
e1150e0
@yccodr
chore: early return on no profile found
ba474d6
@Alonza0314
feat: make return message more clear on porfile part
d66ffb5
@Alonza0314
feat: improve profile confict and not found return message's behavior
e503852
@Alonza0314
feat: improve profile db operation error message behavior
2249b7a
@Alonza0314
refactor: remove gpsi in profile
91d6661
@Alonza0314
fix: solve 404 error when refresh profile page
8423dd7
@Alonza0314
fix: remove gpsi in profile dto
cbc47fc
@Alonza0314
refactor: early return on no subscriber found and show more friendly …
466334d 
…ui when error occurs
@Alonza0314
refactor: rewrite the error handle method with ueid already exists in…
bae7045 
… subscriber create function
ianchen0119
ianchen0119 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@ianchen0119 ianchen0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ianchen0119
Copy link
Contributor

TODO: add edit btn here @Alonza0314
image

@ianchen0119 ianchen0119 merged commit 2253502 into free5gc:main Nov 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianchen0119 ianchen0119 ianchen0119 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alonza0314 @ianchen0119 @yccodr