Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: title of mario block in help categories #1339

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

moT01
Copy link
Member

@moT01 moT01 commented Feb 11, 2025

Hey @Sembauke @Nirajn2311 - I am renaming this block and title on the main repo - will link the PR for that when it's ready. Found this in the mobile codebase. Would it be better to just include both titles for now?

Checklist:

Closes #XXXXX

@Sembauke
Copy link
Member

Sembauke commented Feb 13, 2025

Hey @moT01,

If it is not too much trouble which probably serve help-category.json from the static folder on /learn that way we know for sure they are always synced.

If you think that's a good idea, I will handle things from the mobile side.

edit: I see we don't have a separate file for this on /learn and we don't have to. I can fix this solely on the mobile side.

@moT01
Copy link
Member Author

moT01 commented Feb 13, 2025

So is there anything we need to sync or wait for on the mobile side, or can we continue changing this on the main without worry? And should we close this PR or do we still need it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants