chore: move playwright tests from main repo #1341
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
@Sembauke are the Flutter tests expected to fail or did I break something? |
Nirajn2311
requested changes
Feb 17, 2025
Comment on lines
-8
to
-9
| paths: | ||
| - "mobile-app/**" |
There was a problem hiding this comment.
Could you undo this change? We don't want the e2e tests to run for any changes within the mobile API code
Yes, the app CI are expected to fail as forked PRs don't have access to secrets when running the action |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)The rationale is that these tests are of the mobile app, not the learn client. As such it makes more sense for them to be in this repo.
It's a little ugly, though, since we still need to import curriculum data from the main repo.
I converted the spec and test back to js since it did not seem worth configuring TS for two files. At least not right now.