Skip to content

Commit

Permalink
ntp: NULL pointer deref when create_interface() fails
Browse files Browse the repository at this point in the history
Fix NULL pointer dereference when create_interface() fails in
update_interfaces(). The upstream bug report says a typo was introduced
by https://bk.ntp.org/ntp-dev/ntpd/ntp_io.c?PAGE=diffs&REV=66175036PETA6g__fON8oNrjL54Ttw. ep should have been ep2.

Fix obtained from upstream bug report.

PR:		285065
Upstream bug:	https://bugs.ntp.org/show_bug.cgi?id=3939
MFC after:	1 minute
  • Loading branch information
cschuber committed Feb 28, 2025
1 parent 8a3537a commit 628715f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion contrib/ntp/ntpd/ntp_io.c
Original file line number Diff line number Diff line change
Expand Up @@ -1919,7 +1919,7 @@ update_interfaces(
}
else {
DPRINT_INTERFACE(3,
(ep, "updating ", " new - FAILED"));
(ep2, "updating ", " new - FAILED"));

msyslog(LOG_ERR,
"cannot bind address %s",
Expand Down

0 comments on commit 628715f

Please sign in to comment.