patches #19
patches #19
Conversation
| echo '' ; echo ' The proper location for this file is /usr/local/etc' | ||
| exit 1 | ||
| fi | ||
|
|
There was a problem hiding this comment.
You previously committed this, but I reverted it. A user could easily incorrectly create /etc/portmaster.rc file and be confused why it doesn't work.
There was a problem hiding this comment.
Then the error message should be changed. Most tools don't check for random files which happen to have the same name as their config file. Why not check in /usr/local/lib/portmasterrc ?
There was a problem hiding this comment.
Exactly. I see no reason to retain the check for /etc/portmaster.rc; why not 'find / -name portmaster.rc' or 'locate portmaster.rc'
Most tools don't contain extra code to check for irrelevant files and I think the check here is mostly useless given that this support was removed 3 years ago.
That said, this mostly a pointless argument.
There was a problem hiding this comment.
Portmaster is one of the first tools new users will encounter when coming to FreeBSD. The /usr/local/etc is very different than what they are likely used to. They are still likely to place a portmaster.rc file in /etc. It's completely disingenuous to suggest the user may put it into /usr/local/lib or $RANDOM_PLACE. There is absolutely 0 benefit to removing this check and >0 benefit to keeping it.
I thought I had push access to help with some cleanup & bug fixes - but meh