Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce JAILED_DATASET option to poudriere.conf #1197

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arrowd
Copy link
Contributor

@arrowd arrowd commented Jan 2, 2025

Rationale for the change:

We at $WORK are using Poudriere as a part of the CI process. For a selected set of ports we define WITH_TESTING_PORTS, which makes the test target a part of the pipeline. It works quite well for many of ports we're using.

However, one of the projects we've developed requires creating a ZFS dataset as part of its tests. The #1175 PR made it possible for zfs command to run, but no datasets or pools are visible from within the jail. This follow-up change passes through a throw-away ZFS dataset into the jail and gives full access to it.

I understand that the feature is quite niche, but it doesn't add much complexity to the code, so I hope it will be accepted.

This option allows passing a temporary ZFS dataset into the jail along with
full control over it from within the jail.

Sponsored by:	Future Crew, LLC
@bdrewery
Copy link
Member

bdrewery commented Feb 8, 2025

Could we add some hooks, or use existing hooks, to achieve this?

@arrowd
Copy link
Contributor Author

arrowd commented Feb 9, 2025

I agree, the hooks feels like a more proper place for this feature, but from what I gather, even the "jail start" hook is ran after the jail is actually created, so there is no way for it to pass allow.mount=1 allow.mount.zfs=1 enforce_statfs=1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants