Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly unset internalness of sd-app and sd-proxy #1237

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Explicitly unset internalness of sd-app and sd-proxy #1237

wants to merge 1 commit into from

Conversation

deeplow
Copy link
Contributor

@deeplow deeplow commented Jan 16, 2025

With #1219 sd-app and sd-proxy were explicitly as "internal: 0". However, this does not work, as the developer docs warn 1:

Some extensions interpret the values as boolean. In this case,
the empty string means False and non-empty string (commonly '1')
means True.

To fix this, the internalness of a qube is explicitly set to "".

Status

Ready for review

Description of Changes

Refs #1219

Testing

  • deploy version from main (may be developer environment)
  • restart the Applications Menu: `pkill qubes-app-menu && qubes-app-menu)
  • ensure sd-app and sd-gpg is not present (this is the bug)
  • deploy this branch via make dev
  • restart the Applications Menu: `pkill qubes-app-menu && qubes-app-menu)

Deployment

Any special considerations for deployment? Consider both:

  1. Upgrading existing pilot instances
  2. New installs

Checklist

If you have made changes to the provisioning logic

  • All tests (make test) pass in dom0

If you have added or removed files

  • I have updated MANIFEST.in and rpm-build/SPECS/securedrop-workstation-dom0-config.spec

If documentation is required

  • I have opened a PR in the docs repo for these changes, or will do so later
  • I would appreciate help with the documentation

@deeplow
Explicitly unset internalness of sd-app and sd-proxy
3e83087 
With freedomofpress#1219 sd-app and sd-proxy were explicitly as "internal: 0".
However, this does not work, as the developer docs warn [1]:

> Some extensions interpret the values as boolean. In this case,
> the empty string means False and non-empty string (commonly '1')
> means True.

To fix this, the internalness of a qube is explicitly set to "".

[1]: https://dev.qubes-os.org/projects/core-admin-client/en/latest/manpages/qvm-features.html#description
@deeplow deeplow requested a review from a team January 16, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
SecureDrop dev cycle
Status: Ready For Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deeplow