Tell workstation-ci which Qubes version to use for tests #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mig5
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Looks good to me!
I guess we'll still want two source branches with differing versions of this file (and assume feature branches will branch off of those two branches respectively), I'll leave that to you / @zenmonkeykstop as to making those branches and adjusting this for the 4.2 branch (I assume main branch will be renamed to the 4.1 branch ?)
|
|
As we move towards 4.2, we'll still have a 4.1 branch for backports, so the CI runner needs to know which Qubes version to test against. Having this file will tell it what to do and avoids us from needing special branch prefixes and is hopefully future-proof. Refs <freedomofpress/infrastructure#4603 (comment)>.
|
(just rebased) |
zenmonkeykstop
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
As we move towards 4.2, we'll still have a 4.1 branch for backports, so the CI runner needs to know which Qubes version to test against. Having this file will tell it what to do and avoids us from needing special branch prefixes and is hopefully future-proof.
Refs https://github.com/freedomofpress/infrastructure/issues/4603#issuecomment-1942883978.
Testing