nir/validate: assume() that hashtable entry exists

At this point, it would require a logic error in nir_validate to not have already populated this hashtable entry, but coverity doesn't realize that: CID 1265547 (#1 of 1): Dereference null return value (NULL_RETURNS)3. dereference: Dereferencing a null pointer entry. CID 1271039 (#1 of 1): Dereference null return value (NULL_RETURNS)3. dereference: Dereferencing a null pointer entry. Signed-off-by: Rob Clark <[email protected]> Reviewed-by: Matt Turner <[email protected]>
freedreno-zz · May 20, 2016 · df361fc · df361fc
1 parent fcd6b3f
commit df361fc
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/compiler/nir/nir_validate.c b/src/compiler/nir/nir_validate.c
@@ -879,6 +879,7 @@ postvalidate_reg_decl(nir_register *reg, validate_state *state)
 {
    struct hash_entry *entry = _mesa_hash_table_search(state->regs, reg);
 
+   assume(entry);
    reg_validate_state *reg_state = (reg_validate_state *) entry->data;
 
    nir_foreach_use(src, reg) {
@@ -955,6 +956,8 @@ postvalidate_ssa_def(nir_ssa_def *def, void *void_state)
    validate_state *state = void_state;
 
    struct hash_entry *entry = _mesa_hash_table_search(state->ssa_defs, def);
+
+   assume(entry);
    ssa_def_validate_state *def_state = (ssa_def_validate_state *)entry->data;
 
    nir_foreach_use(src, def) {