Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mock CLI commands #29

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Add mock CLI commands #29

merged 2 commits into from
Apr 18, 2024

Conversation

konnov
Copy link
Contributor

@konnov konnov commented Apr 18, 2024

Closes #25. I have thought a bit about the CLI commands that we would need. Here is the first mock that contains fetch, list, and verify. To check this PR, simply pull it, compile and play with solarkraft.

@konnov konnov self-assigned this Apr 18, 2024
@konnov konnov added this to the M1: Transaction extractor milestone Apr 18, 2024
thpani
thpani reviewed Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@thpani thpani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the rationale for fetching first, then verifying?

If it's not prohibitively expensive, wouldn't you just fetch on-the-fly during verification?

@konnov
Copy link
Contributor Author

konnov commented Apr 18, 2024 •
edited
Loading

What's the rationale for fetching first, then verifying?

If it's not prohibitively expensive, wouldn't you just fetch on-the-fly during verification?

We don't know yet. It may be expensive in some cases. For now, it is just to separate our work more efficiently :)

@konnov konnov merged commit a4a065b into main Apr 18, 2024
2 checks passed
@konnov konnov deleted the igor/cli-ux branch April 18, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thpani thpani thpani approved these changes

@Kukovec Kukovec Awaiting requested review from Kukovec

@andrey-kuprianov andrey-kuprianov Awaiting requested review from andrey-kuprianov

Assignees

@konnov konnov

Labels
prototyping
Projects
None yet
Milestone
M1: Transaction extractor
Development

Successfully merging this pull request may close these issues.

add mock CLI commands
2 participants
@konnov @thpani